Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a couple obvious tweaks #1166

Closed
wants to merge 2 commits into from
Closed

a couple obvious tweaks #1166

wants to merge 2 commits into from

Conversation

parmentelat
Copy link
Contributor

@parmentelat parmentelat commented Nov 22, 2023

in main we have

  • notebook sometimes written noteboook with 3 o's
  • mainmenu has 2 entries with the same id jp-mainmenu-jupytext-new

at first I tried to file this PR against @mahendrapaipuri's current branch lang_specific_text_nb but could not find their fork so, here it goes..

@mahendrapaipuri
Copy link
Contributor

@parmentelat Cheers for fixing typos!

Seems like due #1165 all CI tests are failing.

@mwouts
Copy link
Owner

mwouts commented Nov 25, 2023

Seems like due #1165 all CI tests are failing.

This should be fixed now (following #1173) - let me rebase this PR...

Copy link

codecov bot commented Nov 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1c6d13) 97.59% compared to head (4a36727) 97.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1166   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files          26       26           
  Lines        4357     4357           
=======================================
  Hits         4252     4252           
  Misses        105      105           
Flag Coverage Δ
external 75.23% <ø> (+0.11%) ⬆️
functional 88.54% <ø> (ø)
integration 76.84% <ø> (ø)
unit 66.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mahendrapaipuri
Copy link
Contributor

@mwouts Dont bother to work on this PR anymore. This is obsolete based on new commits in #1163

@mwouts mwouts closed this Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants