-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the CI #1204
Merged
Merged
Update the CI #1204
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1b9d1b7
Keep dependencies unchanged for now
mwouts 16aae34
Define no_markdown-it-py in the matrix
mwouts e7412ea
Restore publish.yml
mwouts 9f796c9
Update publish.yml following ci.yml
mwouts fa2b429
Update publish.yml following release.yml
mwouts c182892
Start test-conda earlier because it's very long
mwouts e76a9bf
Minor revert
mwouts b1c379a
Version 1.16.1-dev
mwouts File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,24 +17,27 @@ jobs: | |
name: > | ||
🐍 ${{ matrix.python-version }} | ||
${{ matrix.dependency_type && format('({0})', matrix.dependency_type) }} | ||
${{ matrix.markdown-it-py && format('(markdown-it-py {0})', matrix.markdown-it-py) }} | ||
${{ matrix.quarto && '(Quarto)' }} | ||
${{ matrix.no_kernel && '(No kernel)' }} | ||
${{ matrix.markdown-it-py && format('(markdown-it-py {0})', matrix.markdown-it-py) }} | ||
${{ matrix.no_markdown-it-py && '(No markdown-it-py)'}} | ||
runs-on: ubuntu-latest | ||
|
||
strategy: | ||
fail-fast: false | ||
matrix: | ||
python-version: [ "3.8", "3.9", "3.10", "3.11", "3.12"] | ||
experimental: [false] | ||
include: | ||
# Test pre-release versions | ||
- python-version: "3.x" | ||
dependency_type: "pre" | ||
experimental: true # fails with pytest-8.0.0rc1 | ||
# Test minimum markdown-it-py supported (otherwise the most recent version is used) | ||
- python-version: "3.x" | ||
markdown-it-py: "~=2.0" | ||
- python-version: "3.x" | ||
markdown-it-py: false | ||
no_markdown-it-py: true | ||
- python-version: "3.x" | ||
no_kernel: true | ||
- python-version: "3.x" | ||
|
@@ -55,15 +58,16 @@ jobs: | |
python -m pip install | ||
-e '.[test-cov,test-external]' | ||
jupyterlab | ||
${{ matrix.markdown-it-py && format('markdown-it-py{0}', matrix.markdown-it-py) || '' }} | ||
${{ format('markdown-it-py{0}', matrix.markdown-it-py) }} | ||
|
||
- name: Install a Jupyter Kernel | ||
if: ${{ !matrix.no_kernel }} | ||
run: python -m ipykernel install --name python_kernel --user | ||
|
||
- name: Uninstall markdown-it-py | ||
# Markdown-it-py is a dependency of Jupytext, | ||
# but Jupytext should still work if it is not installed | ||
if: ${{ matrix.markdown-it-py == 'false' }} | ||
if: ${{ matrix.no_markdown-it-py }} | ||
run: python -m pip uninstall markdown-it-py --yes | ||
|
||
- name: Install Quarto | ||
|
@@ -84,6 +88,7 @@ jobs: | |
python -m jupyterlab.browser_check | ||
|
||
- name: Test with pytest | ||
continue-on-error: ${{ matrix.experimental }} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually for this one I put the
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's a good suggestion, I will have to follow-up on that one |
||
run: pytest -n logical --cov --cov-report=xml | ||
|
||
- name: Upload coverage | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
"""Jupytext's version number""" | ||
|
||
__version__ = "1.16.0" | ||
__version__ = "1.16.1-dev" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should also add
==1.0
here to track the old dependencyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I tried
~=1.0
at https://github.com/mwouts/jupytext/actions/runs/7512100735, but the installation failed. I don't have time to do further attempts so I will go without that.