Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax error in jupyter_again.py #69

Merged
merged 1 commit into from Sep 13, 2018
Merged

Conversation

cclauss
Copy link

@cclauss cclauss commented Sep 10, 2018

No description provided.

@mwouts
Copy link
Owner

mwouts commented Sep 10, 2018

Interesting! Sure, that python file is incorrect. That's the direct translation of a notebook with ?next in a cell. Do you suggest that lines starting with ? should be escaped? (Why not - we already do that for cell magics...)

@cclauss
Copy link
Author

cclauss commented Sep 11, 2018

If the file extension is .ipy or .ipynb then ?next might be OK but if the file extension is .py then the file should contain valid Python code.

@mwouts
Copy link
Owner

mwouts commented Sep 11, 2018

Sure, I do agree. I just forgot to do that tonight! Will come another day with #73 ...

@mwouts mwouts merged commit b08b25d into mwouts:master Sep 13, 2018
@cclauss cclauss deleted the patch-3 branch September 13, 2018 04:21
mwouts added a commit to mwouts/itables that referenced this pull request Jun 23, 2022
- `itables.options` and the `show` function have a new `column_filters` argument to display individual column search boxes ([#69](mwouts/jupytext#69))
- We have documented DataTables' `dom` option.
- We have introduced a new class `JavascriptFunction` to limit the evaluation of Javascript function to selected ones.
- The documentation is formatted with `black` thanks to a Jupytext & Black pre-commit hook.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants