Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extra cmdline arguments for VisualStudio2013Ultimate #15

Closed
CumpsD opened this issue Mar 6, 2014 · 7 comments
Closed

Allow extra cmdline arguments for VisualStudio2013Ultimate #15

CumpsD opened this issue Mar 6, 2014 · 7 comments

Comments

@CumpsD
Copy link

CumpsD commented Mar 6, 2014

Issue with the following package: https://github.com/mwrock/Chocolatey-Packages/blob/master/VisualStudio2013Ultimate/Tools/ChocolateyInstall.ps1

Here you are grabbing the install arguments for chocolatey, and using them to look through the AdminDeployment.xml to turn features on.

Afterwards you call the exe with the following args: /Passive /NoRestart /AdminFile $adminFile /Log $env:temp\vs.log

However, because of this, I am unable to pass extra args to the installer.

Would it be possible for you to change this, so you keep any unrecognized feature in the install arguments, and pass them on to the installer?

Then we can do the following: cinst VisualStudio2013Ultimate -InstallArguments "WebTools /ProductKey xxxxxxx"

We are using this to setup new dev machines, and now have to manually enter keys afterwards.

@kensykora
Copy link
Contributor

@CumpsD let me know if you'd like a build of https://github.com/kensykora/Chocolatey-Packages where I include this capability, or feel free to pull it down and run cpack yourself, until this can get merged in and published to chocolatey.

@mwrock
Copy link
Owner

mwrock commented Apr 6, 2014

Awesome! I have pulled this in. Just running the packages through my test VMs and then I'll push. Thanks so much for this PR!

@kensykora
Copy link
Contributor

No problem, let me know if you need any support on this.

@mwrock
Copy link
Owner

mwrock commented Apr 8, 2014

I should have mentioned that they were pushed. So we are all set. Thanks a bunch for the pr!

From: Ken Sykora [mailto:notifications@github.com]
Sent: Tuesday, April 8, 2014 8:27 AM
To: mwrock/Chocolatey-Packages
Cc: Matt Wrock
Subject: Re: [Chocolatey-Packages] Allow extra cmdline arguments for VisualStudio2013Ultimate (#15)

No problem, let me know if you need any support on this.


Reply to this email directly or view it on GitHub #15 (comment) .

@kensykora
Copy link
Contributor

Not seeing them in the repository here, and this issue is still open, but I do see it in Chocolatey -- didn't push it to github yet?

@mwrock
Copy link
Owner

mwrock commented Apr 9, 2014

ugh. Exactly. Never pushed. oopsy daisy. Thanks for the nudge.

@mwrock mwrock closed this as completed Apr 9, 2014
@CumpsD
Copy link
Author

CumpsD commented Apr 13, 2014

Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants