Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Hilt 적용하기 #31

Closed
mwy3055 opened this issue Apr 25, 2021 · 3 comments · Fixed by #36
Closed

[Refactor] Hilt 적용하기 #31

mwy3055 opened this issue Apr 25, 2021 · 3 comments · Fixed by #36
Assignees
@mwy3055
Labels
refactor Refactor the code.
Milestone
1.12.3

Comments

@mwy3055
Copy link
Owner

mwy3055 commented Apr 25, 2021

Report which files need refactoring. Provide the absolute path.
Dependency Injection을 사용하는 모든 파일

Describe the problem. Summary from Lint Report is welcomed.
Hilt 적용해 보기

Additional context
Android Developers 참고하기
@mwy3055 mwy3055 added the refactor Refactor the code. label Apr 25, 2021
@mwy3055 mwy3055 self-assigned this Apr 25, 2021
@mwy3055
Copy link
Owner Author

mwy3055 commented Apr 28, 2021

VocaPersistence binding 제공하기 - 나중에 갈아 끼우기 쉽도록

@mwy3055
Copy link
Owner Author

mwy3055 commented Apr 28, 2021

각 Fragment의 ViewModelProvider binding 제공하기

@mwy3055 mwy3055 added this to the 1.12.3 milestone Apr 28, 2021
@mwy3055
Copy link
Owner Author

mwy3055 commented Apr 30, 2021

ViewModel의 VocaRepository에도 적용하기

@mwy3055 mwy3055 linked a pull request May 1, 2021 that will close this issue
MyVoca-31: Fix #31 #36
Merged
mwy3055 added a commit that referenced this issue May 1, 2021
@mwy3055
Merge pull request #36 from mwy3055/MyVoca-31
0bdb999 
MyVoca-31: Fix #31
@mwy3055 mwy3055 closed this as completed May 1, 2021
@mwy3055 mwy3055 mentioned this issue May 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwy3055 mwy3055

Labels
refactor Refactor the code.
Projects
None yet
Milestone
1.12.3
Development

Successfully merging a pull request may close this issue.

MyVoca-31: Fix #31 mwy3055/MyVoca
1 participant
@mwy3055