This repository has been archived by the owner on Jan 30, 2023. It is now read-only.
Added sonar.scala.source version property and removed some sonar api … #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deprecation usage
mwz
reviewed
Feb 18, 2018
| val charset = context.fileSystem().encoding.toString | ||
| val versionProperty = context.config().get("sonar.scala.source") | ||
| val version = | ||
| if (context.config().get("sonar.scala.source").isPresent) versionProperty.get() else "2.11.11" |
There was a problem hiding this comment.
sonar.scala.source might be a little bit confusing given that there is already sonar.sources key in SonarQube.
Since this is related to Scala version, I'd probably name it sonar.scala.version.
There was a problem hiding this comment.
Could you default it to the Scala_2_11 constant from Scaliform?
mwz
reviewed
Feb 18, 2018
| @@ -48,51 +49,53 @@ class ScalaSensorSpec extends FlatSpec with Matchers { | |||
| } | |||
| """ | |||
|
|
|||
| private val scala211 = "2.11.11" | |||
There was a problem hiding this comment.
In the future, we should definitely use ScalaCheck to verify the tests hold for all of the Scala versions supported by this plugin.
|
Thanks for removing some of the deprecations, we've got now only ~60 left to do 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
sonar.scala.sourcefor #2Removed some deprecated sonar api usage