This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Implement Player Character Model #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rary into implement-player-character
…rary into implement-player-character
…rary into implement-player-character # Conflicts: # ParquetClassLibrary/Characters/Being.cs # ParquetClassLibrary/Characters/Character.cs
…rary into implement-player-character
…rary into implement-player-character
…rary into implement-player-character
…rary into implement-player-character
…rary into implement-player-character
Closed
…plement-player-character # Conflicts: # ParquetClassLibrary/Characters/Character.cs
WispyMouse
reviewed
May 7, 2019
WispyMouse
reviewed
May 7, 2019
WispyMouse
reviewed
May 7, 2019
WispyMouse
reviewed
May 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented both the PlayerCharacter model here (it ended up being very similar to the NPC model) and extended the BeingStatus model to support PlayerCharacters.
I feel like the BeingStatus model is going to require heavy revision and extension once I get into really implementing game rules and IO . . . but for now I think this is a decent placeholder.
I also split the Name property for Characters into PersonalName and FamilyName to support names like Missy Titan.
Let me know what you think! :)