Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voodoo #3

Closed
hfossli opened this issue Apr 22, 2014 · 7 comments
Closed

Voodoo #3

hfossli opened this issue Apr 22, 2014 · 7 comments

Comments

@hfossli
Copy link

hfossli commented Apr 22, 2014

:D Could that function be renamed?

https://github.com/mxcl/PromiseKit/blob/master/PromiseKit.m#L19

@mxcl
Copy link
Owner

mxcl commented Apr 22, 2014

Probably, at the time I couldn't think of anything better. It is a private function though. So it's not as important.

@hfossli
Copy link
Author

hfossli commented Apr 22, 2014

Well, reading and understanding the code behind any library is essential to me. I'm sure there are more dev-heads which feels the same about this matter as me.

@mxcl
Copy link
Owner

mxcl commented Apr 22, 2014

Oh I agree completely. I plan to add a few comments and I'll rename voodoo today.

@hfossli
Copy link
Author

hfossli commented Apr 22, 2014

Cool! 👍

@cdzombak
Copy link

@mxcl thank you!

@mxcl mxcl closed this as completed in ab4b5cd Apr 22, 2014
@hfossli
Copy link
Author

hfossli commented Apr 23, 2014

👍

@mxcl
Copy link
Owner

mxcl commented Apr 23, 2014

Let me know if you want more documentation. I am typically a little sparse with code comments.

Charlisim referenced this issue in 24i/PromiseKit Aug 12, 2019
RomanPodymov added a commit that referenced this issue Jun 1, 2024
Co-authored-by: Max Howell <mxcl@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants