Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When 2 guarantees #1302

Merged
merged 5 commits into from
Jan 19, 2023
Merged

When 2 guarantees #1302

merged 5 commits into from
Jan 19, 2023

Conversation

RomanPodymov
Copy link
Collaborator

@RomanPodymov RomanPodymov commented Jan 19, 2023 •
edited
Loading

Hello.
Thank you for PromiseKit.
Added when(guarantees:) for 2 guarantees.
Fix #1303.

mxcl
mxcl reviewed Jan 19, 2023
View reviewed changes
Copy link
Owner

@mxcl mxcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to know if we must change the CI versions

.github/workflows/ci.yml Show resolved Hide resolved
@mxcl mxcl merged commit 3ef2ca5 into mxcl:v6 Jan 19, 2023
@RomanPodymov RomanPodymov deleted the guarantees branch January 19, 2023 23:07
@RomanPodymov RomanPodymov mentioned this pull request Jan 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxcl mxcl mxcl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Could not find Xcode version that satisfied version spec: '12.4'
2 participants
@RomanPodymov @mxcl