Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string formats #2

Merged
merged 2 commits into from
Apr 22, 2014
Merged

Fix string formats #2

merged 2 commits into from
Apr 22, 2014

Conversation

robinwit
Copy link
Contributor

It's early here, so I might be a little bit cross-eyed, but I think these are some copy/paste mistakes.

Edit: and also the 'WIP' only just caught my eye. Oh well… 😬

@mxcl
Copy link
Owner

mxcl commented Apr 22, 2014

I can see your intent, but stringByAppendingString doesn't take a format. Probably however it should use stringWithFormat as that is way more common. If you adapt the PR I'll merge. Thanks.

@mxcl
Copy link
Owner

mxcl commented Apr 22, 2014

Oh my bad, I misread the diff. You are absolutely right.

mxcl added a commit that referenced this pull request Apr 22, 2014
@mxcl mxcl merged commit fbf3a61 into mxcl:master Apr 22, 2014
caldrian pushed a commit to codestruction-eu/PromiseKit that referenced this pull request Nov 20, 2021
Fixed typo in README.md.
RomanPodymov added a commit that referenced this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants