subversion: install --ruby fails if brewed ruby is present

[jeffstyr]

Running brew install subversion --ruby will fail if there is a brew-installed ruby 1.9, because subversion requires 1.8 and it's finding the 1.9.

The attached fix sets a few paths explicitly to the system ruby location, and sets a more specific ruby library version so that 1.8 will get used. This allows the install to succeed.

[adamv]

Please only include the change to Subversion in this pull request; changes to homebrew itself should be in a separate request.

[jeffstyr]

I ordered the commits so that the first one only contains the minimal changes and omits the general code improvements, so you can merge just jeffstyr/homebrew@b6c0e11 and that will skip the other changes. (The commits are showing up out-of-order here in the issue view above, but that's the first commit.)

[adamv]

I understand, but it makes it hard to review pull requests when they have mixed changes in them like this.

[jeffstyr]

Understood, but at this point I think that's the easiest way forward with this pull request. (I'm not sure if it's possible to attach a new branch here, and rebasing a publicly pushed branch is considered bad form.) But let me know what you want me to do.

[jeffstyr]

Oh actually, wait, I can move the branch tip back.

[jeffstyr]

Okay done.

[adamv]

You can git checkout -b new-branch, switch to the old branch, reset hard back to the single commit, git push -f to update the existing pull request, and still have the other changes in the new branch.

[jeffstyr]

Yep already taken care of. Momentary lapse there.

[adamv]

We'll want to use the new MacOS::SYSTEM_RUBY const that was added today, and use the library path out of /System/Frameworks rather than /usr/lib.

[jeffstyr]

Ha yes, that's what was in my original commit that you had me move back (using that constant, and having it point to the full path of the system Ruby down inside /System/Frameworks). I can fix it up.

[jeffstyr]

Was the SYSTEM_RUBY const fix merged? I don't see it in master. (And if you haven't merged it yet, you can cherry-pick my jeffstyr/homebrew@9b3aa73, which is where I implemented it originally.)

(Also I did it as SYSTEM_RUBY_HOME rather than SYSTEM_RUBY, since you want the path to the base Ruby dir, rather than the path all the way to the executable, so you can make paths to lib.)

[adamv]

Pinging @jacknagel - the change is on his branch; I thought it was in master but I was mistaken.

[jacknagel]

Haven't merged it yet.

[jeffstyr]

Okay ping when you have and I'll fix this up. (See above my note about path-to-ruby-executable v. path-to-ruby-base-dir.)

[adamv]

Ping -- can I take this pull request and clean it up? Don't want to wait for a CONST if this solves problems now.

[adamv]

Giving me:

subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c:1618:38: error: implicit declaration of function 'rb_errinfo' is invalid in C99
      [-Werror,-Wimplicit-function-declaration]
                                     rb_errinfo(),

[adamv]

Doing this on Snow Leopard and trying to use the bindings gives me:

$ /usr/bin/irb
>> require 'svn/core'
LoadError: dlopen(/Library/Ruby/Site/1.8/universal-darwin10.0/svn/ext/core.bundle, 9): Library not loaded: /usr/local/Cellar/neon/0.29.0/lib/libneon.27.dylib
  Referenced from: /Library/Ruby/Site/1.8/universal-darwin10.0/svn/ext/core.bundle
  Reason: Incompatible library version: core.bundle requires version 30.0.0 or later, but libneon.27.dylib provides version 29.0.0 - /Library/Ruby/Site/1.8/universal-darwin10.0/svn/ext/core.bundle
    from /Library/Ruby/Site/1.8/universal-darwin10.0/svn/ext/core.bundle
    from /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/rubygems/custom_require.rb:31:in `require'
    from /Library/Ruby/Site/1.8/svn/error.rb:2
    from /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require'
    from /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/rubygems/custom_require.rb:31:in `require'
    from /Library/Ruby/Site/1.8/svn/core.rb:6
    from /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require'
    from /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/rubygems/custom_require.rb:31:in `require'
    from (irb):1
>> 

[adamv]

MacPorts is setting "needs_relink" to no, among other things; https://trac.macports.org/browser/trunk/dports/devel/subversion-rubybindings/Portfile

[MikeMcQuaid]

@adamv Thoughts?

[adamv]

I have been too lazy to really dig into this.

[adamv]

brew install ruby and then brew install subversion --ruby worked for me on Lion, under superenv.

Fails under std env, of course.