Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

homebrew fails to upgrade python 2.7.4 - patch failure #19377

Closed
epifanio opened this issue Apr 23, 2013 · 3 comments
Closed

homebrew fails to upgrade python 2.7.4 - patch failure #19377

epifanio opened this issue Apr 23, 2013 · 3 comments
Labels

Comments

@epifanio
Copy link

trying to upgrade my system with "brew upgrade"

the python package fails with an error patching the src code : https://gist.github.com/epifanio/e6ee382dfc7440b49ae8

@apjanke
Copy link
Contributor

apjanke commented Apr 24, 2013

Looks like this only happens if the --with-dtrace option is specified. Plain brew install python works for me on 10.8.3, but brew install python --with-dtrace fails with these same patch errors. Suspect that the --with-dtrace is being picked up from the reporter's prior installation of python. (Maybe persistent options would be a useful thing to include in the brew upgrade output, at least in --verbose?)

The most recent commit to the python.rb formula says it removed the --with-dtrace option, and the option 'with-dtrace' line is commented out. (fbf7be9) But the patches section still references with-dtrace (at the end of a long line so it's hard to see) and seems to be active.

As a workaround, do a brew rm python; brew install python and it may work.

@apjanke
Copy link
Contributor

apjanke commented Apr 24, 2013

And even though the "option" line is commented out, some more logic is left in, so --with-dtrace will still cause configure to be called with it. That probably shouldn't happen. I'm going to adjust the formula to comment out all the with-dtrace logic so it's cleanly disabled.

$ brew install python --with-dtrace |tee python-build-withdtrace.out
==> Downloading http://www.python.org/ftp/python/2.7.4/Python-2.7.4.tar.bz2
Already downloaded: /Library/Caches/Homebrew/python-2.7.4.tar.bz2
==> ./configure --prefix=/usr/local/Cellar/python/2.7.4 --enable-ipv6 --datarootdir=/usr/local/Cellar/python/2.7.4/share --datadir=/usr/local/Cellar/python/2.7.4/share --enable-framework=/usr/local/Cellar/python/2.7.4/Frameworks --without-gcc --with-dtrace CFLAGS=-I/usr/local/include -I/usr/local/opt/sqlite/include LDFLAGS=-L/usr/local/lib -L/usr/local/opt/sqlite/lib MACOSX_DEPLOYMENT_TARGET=10.8

@adamv
Copy link
Contributor

adamv commented Apr 27, 2013

Addressed by 1747136

@adamv adamv closed this as completed Apr 27, 2013
@Homebrew Homebrew locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants