Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

New formula: git-diff-grep #8913

Closed
wants to merge 1 commit into from
Closed

Conversation

bilke
Copy link
Contributor

@bilke bilke commented Dec 1, 2011

This tool will run grep in the last n commit diffs that you specify.

head "https://github.com/oscardelben/git-diff-grep.git"

def install
bin.install "git-diff-grep" => "git-diff-grep"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The => syntax is only necessary when you're renaming the file. If the name is staying the same, you can write it shorter as bin.install "git-diff-grep"

@jacknagel
Copy link
Contributor

Perhaps other maintainers disagree, but I am generally -1 on "git wrapper script foo" as candidates for core, unless there is user demand.

Obviously I haven't used this, but how does it differ from things like git log with -S<string> or -G<regex>?

end

def test
system "brew test git-diff-grep"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong; brew test invokes this test method.

@mistydemeo
Copy link
Member

While I can see the convenience in tracking version information, this kind of simple script doesn't have any complex installation and could be curled into /usr/local by the user about as easily as it could be brew installed. User demand sounds like a good metric to me.

In this case there's no stable version and HEAD is changing rapidly so it's not the best formula candidate in any case.

@adamv
Copy link
Contributor

adamv commented Dec 1, 2011

-1 on this as it stands.

There are a couple options though.

@Sharpie
Copy link
Contributor

Sharpie commented Dec 1, 2011

We do have some script wrappers and it is nice to easily manage installation/uninstallation.

However, -1 on another HEAD-only wrapper.

I'll be downvoting these in general once multi-repo support is finalized.

@jacknagel
Copy link
Contributor

Closing; head-only wrappers are usually a non-starter these days.

@jacknagel jacknagel closed this Jan 24, 2012
@bilke bilke deleted the git-diff-grep branch March 3, 2014 06:43
@Homebrew Homebrew locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants