Conversation
head "https://github.com/oscardelben/git-diff-grep.git" | ||
|
||
def install | ||
bin.install "git-diff-grep" => "git-diff-grep" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The =>
syntax is only necessary when you're renaming the file. If the name is staying the same, you can write it shorter as bin.install "git-diff-grep"
Perhaps other maintainers disagree, but I am generally -1 on "git wrapper script foo" as candidates for core, unless there is user demand. Obviously I haven't used this, but how does it differ from things like |
end | ||
|
||
def test | ||
system "brew test git-diff-grep" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong; brew test
invokes this test method.
While I can see the convenience in tracking version information, this kind of simple script doesn't have any complex installation and could be In this case there's no stable version and |
-1 on this as it stands. There are a couple options though.
|
We do have some script wrappers and it is nice to easily manage installation/uninstallation. However, -1 on another HEAD-only wrapper. I'll be downvoting these in general once multi-repo support is finalized. |
Closing; head-only wrappers are usually a non-starter these days. |
This tool will run grep in the last n commit diffs that you specify.