Backport Emacs HEAD's fullscreen mode option #23729
Conversation
Wonderful work.thanks for your work |
@MikeMcQuaid any objection to me pulling this? |
@adamv If you want it, sure. I'd rather we waited given it required "minimal changes" that could break other things. |
@MikeMcQuaid I don't use this feature myself, no |
Since this patch is based on upstream, I want to pull it in since it is a widely requested feature. @scotchi can you rebase on the current emacs formula? |
This makes it possible to bypass OS X's fullscreen mode. The changes were pulled from Emacs's bzr repository with minimal changes to get them to work with 24.3
Ok, I reworked the commit against the current homebrew master. |
Oh, and for the record, there was no original code that I had to rework for this -- it was just a matter of moving a couple of blocks around to a slightly different place in the file where diff wasn't smart enough to make them apply cleanly. |
"rework" was too strong a word perhaps, I just meant "rebase". |
This makes it possible to bypass OS X's fullscreen mode. The changes were pulled from Emacs's bzr repository with minimal changes to get them to work with 24.3 Closes Homebrew#23729. Signed-off-by: Adam Vandenberg <flangy@gmail.com>
@scotchi Thanks very much, much appreciated! 🎆 |
This makes it possible to bypass OS X's fullscreen mode. The changes were pulled from Emacs's bzr repository with minimal changes to get them to work with 24.3 Closes Homebrew#23729. Signed-off-by: Adam Vandenberg <flangy@gmail.com>
This makes it possible to bypass OS X's fullscreen mode. The changes
were pulled from Emacs's bzr repository with minimal changes to get
them to work with 24.3
This resolves the issues folks had (e.g. #15448) with the now exclusive use of OS X's fullscreen and makes it possible to get behavior similar to the behavior back when homebrew included a fullscreen patch.
And again, this is stuff coming down the pipe from upstream anyway. This just pulls in the current configurable behavior from their repo. With this patch applied you can switch to the old fullscreen behavior by setting: