Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Formula for Gobby #5968

Closed
wants to merge 3 commits into from
Closed

Formula for Gobby #5968

wants to merge 3 commits into from

Conversation

marnen
Copy link
Contributor

@marnen marnen commented Jun 10, 2011

This is a formula for Gobby, a widely used collaborative editor (see http://gobby.0x539.de/). The pull request also includes net6 and obby, which are also developed by the Gobby project, and which Gobby depends on.

@marnen
Copy link
Contributor Author

marnen commented Jun 17, 2011

Maintainers, do you need any further information in order to accept this pull request?

@marnen
Copy link
Contributor Author

marnen commented Aug 9, 2011

I've had no contact from anyone in nearly 2 months, and the pull request hasn't been accepted or rejected. What gives?

@jacknagel
Copy link
Contributor

Few maintainers, many issues, I think.

But in the meantime, you will probably need to restructure this to one formula per commit for it to be merged.

@marnen
Copy link
Contributor Author

marnen commented Aug 10, 2011

I'd be less surprised about lack of contact if previous pull requests hadn't been dealt with in a matter of days.

I know the guideline is one formula per commit, but I'm having a hard time seeing how that makes sense here. Net6 and obby are dependencies of Gobby and really have little or no independent utility, so doesn't it make sense for them all to be in one commit?

@marnen
Copy link
Contributor Author

marnen commented Aug 30, 2011

Bumping in hopes of getting a response. Maintainers, what do you need from me here?

@jacknagel
Copy link
Contributor

Needs to be one commit per formula, one formula per commit. Thanks.

@marnen
Copy link
Contributor Author

marnen commented Aug 30, 2011

Oh, are you a maintainer now? Your earlier comment implied you weren't.

@marnen
Copy link
Contributor Author

marnen commented Aug 30, 2011

OK, here we go. Honestly, I think this is a bit silly, but if it makes you happy...enjoy! :)

@jacknagel
Copy link
Contributor

We like to keep a clean linear history with one logical change per commit (e.g. a formula update or a new formula). Someone want to review this? @adamv @Sharpie

@marnen
Copy link
Contributor Author

marnen commented Aug 30, 2011

Understood. I think, however, that something like this is one logical change despite being three formulae: as I mentioned earlier, net6 and obby are only needed because they're gobby dependencies.

@jacknagel
Copy link
Contributor

Without looking at it too closely, if they are only need for Gobby, perhaps they could be done as sub-brews. See the git formula for an example.

@marnen
Copy link
Contributor Author

marnen commented Aug 30, 2011

Interesting. I wasn't aware of that feature.

@marnen
Copy link
Contributor Author

marnen commented Aug 30, 2011

On reflection, though, it may make more sense as is. Sobby (another package in the Gobby project, which I didn't make a formula for) also depends on Obby.

However, since I think only Obby depends on Net6, that maybe should be a sub-brew. Hmmm.

@adamv
Copy link
Contributor

adamv commented Feb 19, 2012

I'm working on merging this, but getting a compile error on a dep: #10332

@marnen
Copy link
Contributor Author

marnen commented Feb 20, 2012

OK. I'll see what I can figure out.

@cyounkins
Copy link

Got gtksourceview to compile with glib 2.28.6, but gobby still doesn't work:

$ gobby
dyld: Library not loaded: /usr/local/lib/libgobject-2.0.0.dylib
Referenced from: /usr/local/lib/libxml++-2.6.2.dylib
Reason: Incompatible library version: libxml++-2.6.2.dylib requires version 3001.0.0 or later, but libgobject-2.0.0.dylib provides version 2801.0.0
Trace/BPT trap

Perhaps this would be a good time to update the recipe to use libinfinity instead of net6 and obby.

@marnen
Copy link
Contributor Author

marnen commented Mar 27, 2012

I'll take a look when I have a chance.

@adamv
Copy link
Contributor

adamv commented Apr 24, 2012

Finally pulled these; had to go with the newer 0.4.94 version and added libinfinity as well.

@adamv adamv closed this Apr 24, 2012
@marnen
Copy link
Contributor Author

marnen commented Apr 26, 2012

Thanks! Let me know if there are any further issues.

@Homebrew Homebrew locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants