-
-
Notifications
You must be signed in to change notification settings - Fork 11.4k
Conversation
Maintainers, do you need any further information in order to accept this pull request? |
I've had no contact from anyone in nearly 2 months, and the pull request hasn't been accepted or rejected. What gives? |
Few maintainers, many issues, I think. But in the meantime, you will probably need to restructure this to one formula per commit for it to be merged. |
I'd be less surprised about lack of contact if previous pull requests hadn't been dealt with in a matter of days. I know the guideline is one formula per commit, but I'm having a hard time seeing how that makes sense here. Net6 and obby are dependencies of Gobby and really have little or no independent utility, so doesn't it make sense for them all to be in one commit? |
Bumping in hopes of getting a response. Maintainers, what do you need from me here? |
Needs to be one commit per formula, one formula per commit. Thanks. |
Oh, are you a maintainer now? Your earlier comment implied you weren't. |
OK, here we go. Honestly, I think this is a bit silly, but if it makes you happy...enjoy! :) |
Understood. I think, however, that something like this is one logical change despite being three formulae: as I mentioned earlier, net6 and obby are only needed because they're gobby dependencies. |
Without looking at it too closely, if they are only need for Gobby, perhaps they could be done as sub-brews. See the git formula for an example. |
Interesting. I wasn't aware of that feature. |
On reflection, though, it may make more sense as is. Sobby (another package in the Gobby project, which I didn't make a formula for) also depends on Obby. However, since I think only Obby depends on Net6, that maybe should be a sub-brew. Hmmm. |
I'm working on merging this, but getting a compile error on a dep: #10332 |
OK. I'll see what I can figure out. |
Got gtksourceview to compile with glib 2.28.6, but gobby still doesn't work: $ gobby Perhaps this would be a good time to update the recipe to use libinfinity instead of net6 and obby. |
I'll take a look when I have a chance. |
Finally pulled these; had to go with the newer 0.4.94 version and added libinfinity as well. |
Thanks! Let me know if there are any further issues. |
This is a formula for Gobby, a widely used collaborative editor (see http://gobby.0x539.de/). The pull request also includes net6 and obby, which are also developed by the Gobby project, and which Gobby depends on.