gimp 2.8.0

[Frizlab]

Note that this pull request depends on my other two pull requests: babl and gegl

[adamv]

Nice! Though we'll almost certainly need to get png support working before merging this.

[Sharpie]

For reference:

• babl: Added the babl formula #6945
• gegl: Added the gegl formula #6946

[Sharpie]

babl and gegl have been pulled, sorry about the delay.

[Frizlab]

The new commit adds support for png, and depends on #8855 (libpng12).

[cpence]

I know this is an aside, for which I apologize, but since you've been working on Gimp compilation, do you know offhand how hard it would be to bump this to the 2.7 betas? I've been anxious to try Gimp's single-window-mode on OS X.

[Frizlab]

@cpence I actually already created a formula for the betas of gimp. Pushing it right now in a new branch for ya :)

[Frizlab]

@cpence see branch gimp-dev for the development version of gimp

[Frizlab]

New commit now have support for libpng15. #8855 (libpng12) is no longer needed.

[nebiros]

so, isn't merged yet? :S

[LinusU]

@Frizlab do you think that you can bump the version to 2.6.12, it is suppose to be "the final 2.6 release".

Also, is this going to be merged anytime soon, I would LOVE to see this in homebrew!

[Frizlab]

@LinusU I will try and do this ASAP

[LinusU]

@Frizlab that's great, and thanks for the fast reply.

I'm gonna try this formula as soon as I figure out how to switch branch on my local homebrew installation (or fail and just apply the patches manually :D ) and report back if it works. Won't be able to do it tonight thought but hopefully during the weekend.

[LinusU]

@Frizlab, Nice! I just tested your formula (2.6.12) and it worked great! Thanks for taking the time to make this formula, hope it gets merged soon :)

[LinusU]

Noticed some interesting things,

1. The patches still has references to 2.6.11, I guess that this dosen't make any difference since it worked.
2. I managed to build Gimp 2.7.4 without any patches at all, I think that we should add "--devel" support to this formula. It should be easy enough

Additions I did to the formula:

devel do
  url 'ftp://ftp.gimp.org/pub/gimp/v2.7/gimp-2.7.4.tar.bz2'
  md5 'bda95a29c3483b8ff458b06b1543f867'
end

In def patches:

DATA if not ARGV.build_devel?

My ruby skills are very close to none so I might have missed something important but it built a functional gimp for me so I guess I'm not that bad.

[Frizlab]

I don't know if Homebrew allows flags for dev releases of formulas. I did however created a separate branch of my fork of Homebrew in which there is the development version of gimp (2.7.3).

[nebiros]

@Frizlab take a look to the Formula Cookbook, in the "Unstable versions (HEAD, devel)" section you can use a git, svn, mercurial, etc, repository for unstable versions.

[Frizlab]

My bad. I will do the changes ASAP.

[LinusU]

Ahh, good. I also tried to add HEAD-support to the formula, but it didn't work. ./configure exits with status 1, and I don't really have time to look at it right now. Great to have the devel version in thought!

[fabiopelosin]

Not sure if it is an issue on my side but I'm not able to install the devel version. It exits with an error during pango make install.

2.6.12 works fine and brew doctor does not report any issue.

By the way thanks for this formula!

[Frizlab]

@irrationalfab It seems it is not an issue about the gimp formula. When installing the devel version of gimp, all the dependencies are installed in devel mode. Apparently, pango fails to compile in devel mode.

[fabiopelosin]

Thank you for the quick reply. Strangely brew install --devel pango did the trick. And now I'm enjoying gimp single window gimp on OS X.

[garu]

Hey guys, any updates on this one?

[Frizlab]

I updated the formula as asked by @adamv.

[yuvadm]

+1'ing this, would love to see this merged. Definitely willing to help test this out before merging.

[adamv]

==> Summary
/Users/adamv/homebrew/Cellar/gimp/2.6.12: 2015 files, 59M, built in 12.4 minutes
[~/homebrew] (gimp)
$ gimp
Xlib:  extension "RANDR" missing on display "/tmp/launch-YCA2mE/org.x:0".

(script-fu:35776): LibGimpBase-WARNING **: script-fu: gimp_wire_read(): error
Segmentation fault

[Frizlab]

@adamv On what platform did you test this formula?

[LinusU]

@Frizlab, some days ago the GIMP team released a new version of gegl, babl and gimp. I think it would be very wise to bump the devel version in this one to 2.8-rc1 and to update the gegl and babl formulas. What do you think?

Also, thanks for taking the time to get GIMP into Homebrew, it is really appreciated.

[adamv]

OS X 10.6.8 / Xcode 3.2.6 / Core 2 Duo

[Frizlab]

I don't have Snow Leopard at home. I will try and update the formula to correct the crash on Snow Leopard as soon as possible. If someone have an idea to try first, I'm willing to take it.

@LinusU I will update babl, gegl and the devel versions of Gimp. Thanks for notifying me :)

[phmongeau]

I updated glib and recompiled gimp, but I still get the same error.

@Sharpie: Yes, I'm on Snow Leopard. How do I make sure that Pango links to Hombrew's Cairo?

[nebiros]

Can't compile gegl 0.2, the issue: #12063 (comment)

[Sharpie]

Yes, I'm on Snow Leopard. How do I make sure that Pango links to Hombrew's Cairo?

A bit of a mess unfortunately. brew edit pango, make it depend_on 'cairo' unconditionally and then re-build the rest of the GTK tree.

[phmongeau]

@Sharpie: That worked, thanks!

[Sharpie]

Glad to hear it! Everything should be sorted put when #11328 is closed.

[nebiros]

Works great!, I just do this:

• Remove cairo.
• Remove gtk+.
• Install intltool (gegl issue).
• Install GIMP 2.8.
• Done.

$ brew --config
HOMEBREW_VERSION: 0.9
HEAD: 0235e587da10cd97ad60bf1b5f25904667b5189c
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CELLAR: /usr/local/Cellar
CPU: dual-core 64-bit penryn
OS X: 10.7.4
Kernel Architecture: x86_64
Xcode: 4.3.2
GCC-4.0: N/A
GCC-4.2: N/A
LLVM: build 2336
Clang: 3.1 build 318
MacPorts or Fink? false
X11: /usr/X11
System Ruby: 1.8.7-357
/usr/bin/ruby => /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/bin/ruby
Which Perl:   /usr/bin/perl
Which Python: /usr/local/bin/python => /usr/local/Cellar/python/2.7.3/bin/python2.7
Which Ruby:   /Users/nebiros/.rbenv/shims/ruby

[idodeclare]

Regarding "dbus/machine-id", glib-2.32 (the latest pushed) is not aware of dbus's launchd support and tries to run "dbus-launch --autolaunch", which does not work on Mac OS X.

I got dbus working via:

1. "brew install d-bus", which provides org.freedesktop.dbus-session.plist to put in my ~/Library/LaunchAgents/ and load via launchctl

2. Set the environment before running gimp as per the following:

#
# glib-dbus (now embedded in glib) does not know launchd, but dbus-1.4 does
# (can be got through "brew install d-bus"), so query launchctl directly
#
DBUS_LAUNCHD_SESSION_BUS_SOCKET=`launchctl getenv DBUS_LAUNCHD_SESSION_BUS_SOCKET`
if test $? -eq 0 -a "${DBUS_LAUNCHD_SESSION_BUS_SOCKET}" != ""
then
    export DBUS_SESSION_BUS_ADDRESS="unix:path=${DBUS_LAUNCHD_SESSION_BUS_SOCKET}"
    echo "Using DBUS_SESSION_BUS_ADDRESS=${DBUS_SESSION_BUS_ADDRESS}"
else
    logger -s "No DBUS_LAUNCHD_SESSION_BUS_SOCKET available."
fi

3. Run gimp

Additionally, I've also forked lisanet.de's gimponosx project as https://github.com/idodeclare/gimponosx. I'm only using lisanet's portion to build a OSX application that wraps up gimp-2.8, and I jettisoned all the macports dependencies.

I also simplified the project so it builds entirely in Xcode. I wonder if it might be possible to get it to a point where Gimp.app could be brewed.

[idodeclare]

I recommend adding dbus-glib as a brew pre-requisite.

After much debugging, I finally deduced that half of gimp is using glib's new "embedded" dbus hooks (see gimp-2.8.0/app/unique.c), but the other half is relying on the deprecated dbus-glib library (see gimp-2.8.0/app/gui/gui-unique.c).

So without dbus-glib, gimp will appear to be fully dbus functional, in that it connects to the dbus-daemon straightaway and sends bus messages, but the portion of gimp which publishes a org.gimp.GIMP.UI service will not be compiled in.

[Frizlab]

dbus-glib is added as an optional dependency to the Gimp formula.
See https://github.com/Frizlab/homebrew/pull/1 for details.

[2bits]

+1 and thanks for all your efforts. From your configure command I guess this runs with the stock X11 on Lion 10.7.4? I was not looking forward to install XQuartz the way Gimp on OSX from lisanet required.

[Frizlab]

Yes it works with the default X11.

[shingonoide]

After @nebiros comment: #8835 (comment) . my gimp was compiled and working.

[adamv]

If dbus is optional there should be a switch for it; since "optional" deps will always be picked up.

[adamv]

Getting a GEGL error on startup:

$ gimp
GEGL-geglmodule.c-Message: Module '/Users/adamv/homebrew/Cellar/gegl/0.2.0/lib/gegl-0.2/ff-load.so' load error: dlopen(/Users/adamv/homebrew/Cellar/gegl/0.2.0/lib/gegl-0.2/ff-load.so, 10): Symbol not found: _av_open_input_file
  Referenced from: /Users/adamv/homebrew/Cellar/gegl/0.2.0/lib/gegl-0.2/ff-load.so
  Expected in: flat namespace
 in /Users/adamv/homebrew/Cellar/gegl/0.2.0/lib/gegl-0.2/ff-load.so

[adamv]

Squash to a single commit for another review, thanks.

[Frizlab]

Squashed to a single commit. But still getting an error on launch. Will work on that when I find some time to spend on the problem. I will also add a switch for dbus.

[yuvadm]

Relevant? http://www.petapixel.com/2012/08/29/gimp-is-now-a-self-contained-native-app-for-mac-os-x/

[Frizlab]

@yuvadm I'm not sure. What I provide in my formula is a command line version of The Gimp that uses X11. A native OS X Gimp is not the same thing. Some might find it better, but for instance, if you use The Gimp without GUI, you would need the command line version of The Gimp.

[yuvadm]

@Frizlab cool. Note that the native app might also be suffering from the same error you're seeing on initial launch.

[Frizlab]

Will check that, when I find the time :)

[Frizlab]

So. Now that Gimp is a native OSX application, the only reason we would want to brew gimp is to have the command line version of gimp.
However, using gimp without GUI is a very rare usage. Therefore, I'm closing this pull request.
I will also remove the gimp branch from my forked homebrew in three weeks.

[karo11]

There could be one reason more for gimp; to build gimp plugins, there should be the environment of gimp! This missing environment is IMHO the largest disadvantage of GimponOSX as well as all other Mac Gimp binaries.

Hence, I would appreciate to have a gimp version in homebrew. Command version or app may be a bit less puristic behaviour could help.

[Frizlab]

Well. I removed the gimp branch of my fork of Homebrew. I didn't backed it up anywhere. Maybe someone forked my fork and the gimp branch is still somewhere on GitHub, I don't know…
Anyway. Compiling The Gimp is now not very difficult assuming all the dependencies are installed on your system. Indeed, Gimp 2.8 is much more Mac friendly than the previous versions. Just run configure and make in the latest tarball and you should be good to go.

EDIT: I deleted the branch, but the commits are still in my fork as I did not delete it. You can still see the formula as it was three months ago by checking the changes made by this pull request.
The integration of the named formula in Homebrew is not up to me though.

[wyatt8740]

I would like to point out that I prefer X11 gimp over native for reasons of taste. I dislike having gimp act differently in OSX than it does in linux/windows, so I like X11 gimp. There is a reason.