Add support for local dependencies #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
If the dependency is not scp or a github dependency with the `@` symbol prefix, we check if the string path is valid in the user's file system using the Path dependency. This way, we still allow github dependencies without the `@` prefix. If determined to be a local dependency, a new `DependencyName` enum case holds the dependency as a Path, which facilitates providing the string for `Package.swift` and when decoding. Moreover, this enum case is used to provide the correct `packageline`. The related test makes use of `Path.home` to have a directory that is valid for testing wherever the test is run. Also, updates README.
Parse regex prefix was updated to allow a `~` prefix using "match one of these characters" syntax — i.e., [~@]. The related test makes use of `Path.home` to have a directory that is valid for testing wherever the test is run. Also, update README
|
It seems a pity to require full paths. My experience with this sort of thing in other packages is 90% of the time you specify a relative path. |
|
Yeah, I agree! I thought of relative paths as I was adding the support for |
|
One way to work around the conflict with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue: #76
Supports local dependencies when full local path is written or using
~/prefix.If the dependency is not scp or a github dependency with the
@symbol prefix, we check if the string path is valid in the user's file system using the Path dependency before setting the dependency as local. This way, we still allow github dependencies without the@prefix.If determined to be a local dependency, a new
DependencyNameenum case holds the dependency as a Path, which facilitates providing the dependency string when generating thePackage.swiftand when decoding. Moreover, this enum case is used to provide the correctpackageline.The related test makes use of
Path.hometo have a directory that is valid for testing wherever the test is run.Also, updates README.