Context menu on samples list stays open

[axelboc]

This is really unexpected and quite annoying especially since it stays open even after navigating away and back to the samples list page.

[marcus-oscarsson]

Yes, and its a bit awkward that it is animated from the bottom up in my opinion.

[marcus-oscarsson]

@jbflo Is it something you think you can have look at when you get some time ?

[walesch-yan]

The context menu on the canvas element in the data collection section shows the exact same behavior. From my understanding, the only way to close them is by clicking on the element that spawned them (i.e. sample, resp. canvas) or its direct parent element. Clicking anywhere on the screen to close them would be a more intuitive solution.

[jbflo]

Maybe we should check again with react-contexify or reat contexMenu that have the necessary events handlers to show or Hide on body click, but in the pass they had some bugs when dealing with long Menu Height. So we had to create this Context Menu component where Show or Hide state are from redux, But forgot to handle the hide when component is Unmounted. Please have a look at the
Related PR for a fix

[axelboc]

Concerning UX, the context menu should ideally be closed right after selecting a menu item. This is what you expect from a typical OS context menu. Unmount is a good start though, I'm not against merging that to mitigate the issue when navigating away and back.

Concerning implementation, if the underlying library can't handle the above easily out of the box, then the state should ideally be managed locally for efficiency and to avoid cluttering global state. But this could be refactored later on, of course.

[axelboc]

Resolved in #1321