Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major dependency update - Flask 3x #1230

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Major dependency update - Flask 3x #1230

merged 1 commit into from
Jun 20, 2024

Conversation

marcus-oscarsson
Copy link
Member

Updating flask to 3.0. Still testing this, seems to work but sill needs some more testing.

@marcus-oscarsson marcus-oscarsson changed the title Major depdency update - Flask 3x [WIP] Major depdency update - Flask 3x Apr 30, 2024
@marcus-oscarsson marcus-oscarsson changed the title [WIP] Major depdency update - Flask 3x [WIP] Major dependency update - Flask 3x Apr 30, 2024
This was referenced May 13, 2024
Closed
Closed
@marcus-oscarsson marcus-oscarsson changed the title [WIP] Major dependency update - Flask 3x Major dependency update - Flask 3x Jun 17, 2024
@marcus-oscarsson marcus-oscarsson marked this pull request as ready for review June 17, 2024 14:42
@marcus-oscarsson
Copy link
Member Author

We have been testing this for about two weeks and we have not seen any issue with the updates

@marcus-oscarsson
Copy link
Member Author

Seems like tests are failing for some reason, ill WIP it for now until I have double checked why that is.

@marcus-oscarsson marcus-oscarsson changed the title Major dependency update - Flask 3x [WIP] Major dependency update - Flask 3x Jun 17, 2024
@marcus-oscarsson marcus-oscarsson changed the title [WIP] Major dependency update - Flask 3x Major dependency update - Flask 3x Jun 18, 2024
@marcus-oscarsson
Copy link
Member Author

Ok, all fine now :)

@fabcor-maxiv
Copy link
Contributor

fabcor-maxiv commented Jun 19, 2024 •
edited
Loading

Seems like tests are failing for some reason, ill WIP it for now until I have double checked why that is.
[...]
Ok, all fine now :)

Did you figure out why the tests were failing? I had a very quick look at the job output the other day, and it seemed like it was related to missing imports (as if the API had changed).

fabcor-maxiv
fabcor-maxiv reviewed Jun 19, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@marcus-oscarsson
Copy link
Member Author

Seems like tests are failing for some reason, ill WIP it for now until I have double checked why that is.
[...]
Ok, all fine now :)

Did you figure out why the tests were failing? I had a very quick look at the job output the other day, and it seemed like it was related to missing imports (as if the API had changed).

Yes it was because flask-login was 0.6.2 and did not support the latest werkzeug so it needs to be at-least 0.6.3

@marcus-oscarsson marcus-oscarsson mentioned this pull request Jun 20, 2024
Closed
@marcus-oscarsson marcus-oscarsson merged commit 0f30a39 into develop Jun 20, 2024
13 checks passed
@marcus-oscarsson marcus-oscarsson deleted the mo-dep branch June 20, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabcor-maxiv fabcor-maxiv fabcor-maxiv left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcus-oscarsson @fabcor-maxiv