Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mockup: show more fields in machine info box #1252

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

elmjag
Copy link
Contributor

@elmjag elmjag commented Jun 18, 2024

When running MXCuBE with mockups, enable more fields in the machine info drop-down box. Let's include 'message' and 'lifetime' fields in addition to 'current', as the MachineInfoMockup implements these fields.

The result looks like this:

image

@beteva
Copy link
Member

beteva commented Jun 18, 2024

@elmjag I did not add all, as wanted to show that you have the choice of not displaying everything.
If you need to add all the rest, please do so.

The idea of the mxcubecore PR #917 - Refactor AbstractMachineInfo and the corresponding mxcubeweb PR #1222 was to be able to add as many fields to display as your HO provides. In the current xml file you have already.

<object class="MachineInfoMockup">
    <parameters>["current", "lifetime", "dummy"]</parameters>
</object>

The dummy in the parameters list serves "test_check_attributes" in the tests, just to create an error, so, please, do not remove it.

@beteva
Copy link
Member

beteva commented Jun 18, 2024

@elmjag, my apologies. I was looking at the wrong xml file - the one on the mxcubecore repository. Anyhow you can add whatever you need.
We need, though, to find a way of having the configuration files in just one place, so there is no repetition or worse - inconsistency.

@elmjag
Copy link
Contributor Author

elmjag commented Jun 19, 2024

I don't have any strong feelings about this change.

My rationale for adding <parameters/> tag is that it gives us a nice example of how you can configure MachineInfo hardware objects. I assume that the mock-ups are commonly studied when trying to understand new parts of MXCuBE.

When running MXCuBE with mockups, enable more fields in the machine
info drop-down box. Let's include 'message' and 'lifetime' fields,
as the MachineInfoMockup implements these fields.
@marcus-oscarsson marcus-oscarsson merged commit 1ff7977 into mxcube:develop Jun 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants