[TaskDialog] - Fix for JSForm getting cleard when store update #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcus-oscarsson
force-pushed
the
mo-task-dialog
branch
from
fb96504
to
b3b0464
Compare
axelboc
approved these changes
Jun 18, 2024
| @@ -43,6 +43,17 @@ class GenericTaskForm extends React.Component { | |||
| this.props.handleSubmit(this.addToQueue.bind(this, true))(); | |||
| } | |||
|
|
|||
| clearCurrentJSFormParameters() { | |||
| localStorage.removeItem(`current${this.props.taskData.type}Parameters`); | |||
There was a problem hiding this comment.
You could make a getter for the local storage key instead — it's the logic that is worth abstracting IMO.
get storageKey() {
return `current${this.props.taskData.type}Parameters`;
}There was a problem hiding this comment.
Oh thats nice :)
marcus-oscarsson
force-pushed
the
mo-task-dialog
branch
from
b3b0464
to
f739d74
Compare
axelboc
reviewed
Jun 20, 2024
| @@ -167,6 +183,18 @@ class GenericTaskForm extends React.Component { | |||
| } | |||
| } | |||
|
|
|||
| const currentFormData = JSON.parse( | |||
| localStorage.getItem(`current${this.props.taskData.type}Parameters`), | |||
| show={this.props.show} | ||
| onHide={() => { | ||
| localStorage.removeItem( | ||
| `current${this.props.taskData.type}Parameters`, |
marcus-oscarsson
force-pushed
the
mo-task-dialog
branch
from
f739d74
to
b243201
Compare
marcus-oscarsson
force-pushed
the
mo-task-dialog
branch
from
b243201
to
f1bf940
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few issues with the generic task dialog.
The "current" values of the JSForm is saved in local storage so that they are not cleared by updates to the redux store (as the redux form gets re-rendered when the store is updated)
Reset to default fixed
Added missing title