Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint YAML files with yamllint #1264

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

fabcor-maxiv
Copy link
Contributor

@fabcor-maxiv fabcor-maxiv commented Jun 26, 2024

There is now a configuration file for yamllint and a pre-commit hook.

The most straightforward linting issues were fixed. The other ones are ignored and should be handled in the future.

@fabcor-maxiv
Copy link
Contributor Author

I started with this because I am planning to do more changes to the pre-commit hooks, and had to first clean up the formatting/linting of the .pre-commit-config.yaml file.

@fabcor-maxiv
Copy link
Contributor Author

We should also do the same for mxcubecore. Especially since we are planning to migrate all configuration to YAML files.

@elmjag
Copy link
Contributor

elmjag commented Jun 27, 2024

+1 for more linting!

There is now a configuration file for `yamllint`
and a `pre-commit` hook.

The most straightforward linting issues were fixed.
The other ones are ignored and should be handled in the future.
@fabcor-maxiv
Copy link
Contributor Author

From my point of view, this is ready for merge. I hope to get started working on the same change for mxcubecore soon-ish.

@marcus-oscarsson
Copy link
Member

Thanks, ok

@marcus-oscarsson marcus-oscarsson merged commit 18f66e6 into mxcube:develop Jun 27, 2024
7 checks passed
@fabcor-maxiv fabcor-maxiv deleted the yaml-files branch June 27, 2024 14:38
@fabcor-maxiv
Copy link
Contributor Author

For mxcubecore: mxcube/mxcubecore#948

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants