Remove unused deps #1267
Merged
Remove unused deps #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice job with the investigation! I will try to give it a check from our side, but there is not much doubt you know this stuff better than we do. : ) |
|
Could we get a pre-commit hook or maybe a GitHub Action to make sure it stays clean? Would that make sense? |
|
Nice, well done and big thanks ! |
marcus-oscarsson
force-pushed
the
usued-deps
branch
from
a4b61ff
to
dc1d286
Compare
Hmm, I feel like it would be a bit brittle and not really worth the effort. An unused dependency just adds a few ms to the installation time; nothing worth worrying about too much in my opinion, especially since it doesn't take long to do a bit of a clean-up like this from time to time. |
fabcor-maxiv
approved these changes
Jun 28, 2024
marcus-oscarsson
force-pushed
the
usued-deps
branch
from
dc1d286
to
6e672e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1242
All in all,
depcheckdid a good job 😊 — I did go over all the deps myself just in case it missed one (it didn't). Do please double check thoroughly.Unused dependencies
dustjs-helpers: used but imported withrequire; kept 🟢dustjs-linkedin: used but imported withrequire; kept 🟢everpolate: unused; removed 🗑️history: unused; removed 🗑️jsmpeg: used viaui/src/components/SampleView/jsmpeg.min.js, not via NPM package, which is obsolete compared tojsmpeg.min.js; removed 🗑️liform-react: unused; removed 🗑️plotly.js: peer of react-plotly.js; unused; removed 🗑️popper.js: unused; removed 🗑️react-clipboard.js: unused; removed 🗑️react-plotly.js: unused; removed 🗑️react-router: peer of react-router-dom; used; kept 🟢react-sticky: unused; removed 🗑️shortid: unused; removed 🗑️underscore: unused; removed 🗑️ws: unused; removed 🗑️Unused devDependencies
@testing-library/react: unused but should be 😂 ; kept for now 🟢@testing-library/user-event: unused but should be 😂 ; kept for now 🟢babel-preset-react-app: direct dep ofcreate-react-app; no need to install ourselves; removed 🗑️concurrently: unused; removed 🗑️less: only one.lessfileui/src/components/PeriodicTable/style.lesswith only a few mixins for CSS browser prefixing; styles should be written in pure CSS; browser prefixing is done automatically byautoprefixerbased onbrowserslistsconfig; removed 🗑️less-watch-compiler: removed 🗑️sass: no SASS/SCSS files found; removed 🗑️wait-on: used in CI to wait for server to start before testing with Cypress; kept 🟢webpack: dependency ofwebpack-dev-server; safer to keep in case specified version range matters 🟢webpack-dev-server: dependency ofreact-scripts; safer to keep in case specified version range matters 🟢Missing dependencies
All of these are direct dependencies of
eslint-config-galex, so no need to install them. 🟢