added custom tag #15
Merged
added custom tag #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LIUSHANYIN
requested review from
ssysm,
mxdi9i7,
z695245771,
WillHHH and
trista8130
mxdi9i7
requested changes
May 25, 2020
src/components/Icons/index.tsx
Outdated
| @@ -10,21 +10,25 @@ interface IProps { | |||
| color?: string; | |||
| size?: string; | |||
| classPrefix?: string; | |||
| tag?: string; | |||
| tag?: 'a'; | |||
| url?: string; | |||
There was a problem hiding this comment.
icons shouldn't have url and replace
src/components/Icons/index.tsx
Outdated
| }: IProps) { | ||
| const CustomTag = tag || 'a'; |
There was a problem hiding this comment.
custom icon tag should be 'i' by default
src/components/Icons/index.tsx
Outdated
| }); | ||
| } else { | ||
| Object.assign(iconProps, { | ||
| target: '_blank' |
There was a problem hiding this comment.
ok. I just think maybe one day we need the icon to be an 'a' tag. I will delete these codes.
z695245771
reviewed
May 26, 2020
src/components/Icons/index.tsx
Outdated
| @@ -10,21 +10,21 @@ interface IProps { | |||
| color?: string; | |||
| size?: string; | |||
| classPrefix?: string; | |||
| tag?: string; | |||
| tag?: 'i'; | |||
There was a problem hiding this comment.
i think tag name should be a string here. 'i' is just the default value, not enum
|
Missing story |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.