-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Divider component #92
Conversation
|
||
$padding-base: 4px; | ||
$padding-md: $padding-base * 4; | ||
$gray-3: #ebedf0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these 2 colors are already defined in colors variables file
|
||
$baseClass: 'vant-divider'; | ||
|
||
$padding-base: 4px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use the spacing variables
$padding-md: $padding-base * 4; | ||
$gray-3: #ebedf0; | ||
$gray-6: #969799; | ||
$font-size-md: 14px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can find the font variables in typography
$divider-margin: $padding-md 0; | ||
$divider-text-color: $gray-6; | ||
$divider-font-size: $font-size-md; | ||
$divider-line-height: 24px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use typography variables
&::before, | ||
&::after { | ||
display: block; | ||
flex: 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need flex:1 if it's display block?
import '../../styles/stories.scss'; | ||
|
||
export default { | ||
title: 'Divier', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Divider
Remember to upgrade package.json version by patch version, and check this item off in README.md |
No description provided.