Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version of protobuf is too old #1269

Closed
pavelvat opened this issue Mar 20, 2016 · 1 comment
Closed

version of protobuf is too old #1269

pavelvat opened this issue Mar 20, 2016 · 1 comment

Comments

@pavelvat
Copy link
Contributor

protobuf.mk currently have version 2.5.0 this leads to incompatibility when build of Clementine: http://pastebin.com/Zr17VsL9
I tried to upgrade protobuf.mk to version 2.6.1 and encountered with a very strange problem http://pastebin.com/cb19jtvt
./autogen.sh trying to download http://googletest.googlecode.com/files/gtest-1.5.0.tar.bz2 and fail. gtest-1.5.0.tar.bz2 is successfully downloaded through internet browser or command line (curl, wget), but it fail when downloading inside MXE.

Workaround for this problem:

wget http://googletest.googlecode.com/files/gtest-1.5.0.tar.bz2
tar fjx gtest-1.5.0.tar.bz2
wget https://github.com/google/protobuf/archive/2.6.1.tar.gz
tar fzx 2.6.1.tar.gz
cp -r protobuf-2.6.1/ protobuf-2.6.1.orig
cp -r gtest-1.5.0 protobuf-2.6.1/
diff -Naur protobuf-2.6.1.orig/ protobuf-2.6.1 > protobuf-1-fixes.patch
cp protobuf-1-fixes.patch /path/to/mxe/src/

clementine.exe was built and launched successfully.

The same problem with protobuf.mk version 3.0.0-beta-2, but with another link https://googlemock.googlecode.com/files/gmock-1.7.0.zip.

@starius
Copy link
Member

starius commented Mar 20, 2016

MXE has a protection against (potentially unverified) downloads during building.

You should create package gtest and unpack its source while building protobuf. It can be done with macro PREPARE_PKG_SOURCE. For example, package upx unpacks source of package uxl. Add gtest to dependencies of protobuf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants