Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-pkg issues #1886

Closed
hurzelchen opened this issue Aug 30, 2017 · 7 comments
Closed

build-pkg issues #1886

hurzelchen opened this issue Aug 30, 2017 · 7 comments

Comments

@hurzelchen
Copy link

hurzelchen commented Aug 30, 2017

I'm currently having to minor issues with build-pkg:

  • It doesn't create a meta-package for qt5 that would just simply reference all dependencies.
  • the packages for mxe-conf and cmake-conf contain conflicting .gitkeep files.
@hurzelchen
Copy link
Author

the x86-64-pc-linux-gnu versions of mxe-conf and cmake-conf also both contain nonetwork.so.

@hurzelchen
Copy link
Author

and a last more cosmetic issue: the Installed-Size field of the debian packages are not set, so apt-get always reports no new disk space to be used.

@starius
Copy link
Member

starius commented Sep 24, 2017

Binary package for qt5 is not created because the package itself is empty.
Empty packages such that no non-empty packages depend on them are skipped after #968
Frankly speaking I don't remember what was the issue with empty packages, probably just a matter of taste. I'll try to change build-pkg to build such packages. Also it is likely to result in its simplification.

@starius
Copy link
Member

starius commented Sep 24, 2017

I've sent the fix in #1906
Can you verify that it builds the qt5 package, please?

@starius
Copy link
Member

starius commented Sep 24, 2017

With regard to the conflicting .gitkeep files, I identified all such files:

$ cat *.list | grep .gitkeep | sort | uniq -d
usr/i686-w64-mingw32.shared/installed/.gitkeep
usr/i686-w64-mingw32.static/installed/.gitkeep
usr/x86_64-unknown-linux-gnu/installed/.gitkeep
usr/x86_64-unknown-linux-gnu/lib/.gitkeep
usr/x86_64-w64-mingw32.shared/installed/.gitkeep
usr/x86_64-w64-mingw32.static/installed/.gitkeep

In all cases a package installs other files to the same library, so these .gitkeep files can be safely added to the blacklist. I'll send a PR.

starius added a commit to LuaAndC/mxe that referenced this issue Sep 24, 2017
The following files are installed by both cmake-conf and mxe-conf:

usr/i686-w64-mingw32.shared/installed/.gitkeep
usr/i686-w64-mingw32.static/installed/.gitkeep
usr/x86_64-unknown-linux-gnu/installed/.gitkeep
usr/x86_64-unknown-linux-gnu/lib/.gitkeep
usr/x86_64-w64-mingw32.shared/installed/.gitkeep
usr/x86_64-w64-mingw32.static/installed/.gitkeep

In all cases a package installs other files to the same library, so these
.gitkeep files can be safely added to the blacklist.

See mxe#1886 (comment)
@starius
Copy link
Member

starius commented Sep 24, 2017

The PR to ignore these .gitkeep files: #1907

@starius
Copy link
Member

starius commented Sep 24, 2017

#1908 was sent to address the Installed-Size issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants