aspell: fix shared linking, disable pthreads, and add archlinux patches

[tonytheodore]

fixes #1143

[pavelvat]

http://pastebin.com/8FxuPmYt

[tonytheodore]

Is this with a clean build or are other packages installed (ls usr/i686-w64-mingw32.shared/installed/)?

[pavelvat]

It is not a clean build:

$ ls usr/i686-w64-mingw32.shared/installed/
aspell       fontconfig          gnutls     libgnurx        lzo        pkgconf         qtenginio           qtsensors       qtwebengine    xz
binutils     freetds             harfbuzz   libgpg_error    mingw-w64  postgresql      qtgraphicaleffects  qtserialport    qtwebkit       zlib
boost        freetype            icu4c      libiconv        miniupnpc  qt3d            qtimageformats      qtservice       qtwebsockets
bzip2        freetype-bootstrap  jpeg       libidn          mxe-conf   qt5             qtlocation          qtsvg           qtwinextras
cairo        gcc                 jsoncpp    libmng          nettle     qtactiveqt      qtmultimedia        qtsystems       qtxlsxwriter
dbus         gettext             lcms       libmysqlclient  openssl    qtbase          qtquick1            qttools         qtxmlpatterns
dlfcn-win32  glib                libffi     libpng          pcre       qtconnectivity  qtquickcontrols     qttranslations  sqlite
expat        gmp                 libgcrypt  lua             pixman     qtdeclarative   qtscript            qtwebchannel    tiff

For clean build all fine, but copydlldeps.py says about libdl.dll.a again:

~/tmp/mxe$ cp ~/tmp/mxe/usr/i686-w64-mingw32.shared/bin/libaspell-15.dll ~/tmp/aspell/
~/tmp/mxe$ ./tools/copydlldeps.py ~/tmp/aspell/ -C ~/tmp/aspell/ -L ~/tmp/mxe/usr/i686-w64-mingw32.shared/bin/
Missing dll files: kernel32.dll, msvcrt.dll, libdl.dll.a, user32.dll

[tonytheodore]

Now I think I'm losing my mind, I can see the same libdl.dll.a issue again.

[tonytheodore]

Okay, I've disabled dlopen and now aspell.exe is working.

I'll see if I can replicate the ordering issue with other packages install.

[pavelvat]

@tonytheodore sorry, but in last time I forgot git checkout aspell after git fetch origin pull/1210/head:aspell for clean MXE build. After git checkout aspell I have the same error http://pastebin.com/8FxuPmYt about undefined reference to libintl_dgettext'` on clean MXE build. I fixed it by adding this lines:

    $(if $(BUILD_SHARED),\
        $(SED) -i 's#^postdeps="-#postdeps="-lintl -#g' '$(1)/libtool')

Now copydlldeps.py says:

~/tmp/mxe$ cp ~/tmp/mxe/usr/i686-w64-mingw32.shared/bin/libaspell-15.dll ~/tmp/aspell/
~/tmp/mxe$ ./tools/copydlldeps.py ~/tmp/aspell/ -C ~/tmp/aspell/ -L ~/tmp/mxe/usr/i686-w64-mingw32.shared/bin/
Missing dll files: advapi32.dll, kernel32.dll, msvcrt.dll, user32.dll

[tonytheodore]

Missing dll files: advapi32.dll, kernel32.dll, msvcrt.dll, user32.dll

Those look reasonable as they are supplied by windows. Is libdl.dll copied to the ~/tmp/aspell/ directory? The log above is prior to disabling it and I'm not sure why it would succeed.

[pavelvat]

Is libdl.dll copied to the ~/tmp/aspell/ directory?

No. I built commit tonytheodore@17a58bd with disabled dlopen + my fix above for libintl.

~/tmp/aspell$ ls
libaspell-15.dll  libgcc_s_sjlj-1.dll  libiconv-2.dll  libintl-8.dll  libstdc++-6.dll

This http://pastebin.com/8FxuPmYt is old log from first message #1210 (comment). I attached old log because new log contained the same error about undefined reference to libintl_dgettext'`.

[tonytheodore]

Okay, added libintl fix above: 50180c2

[pavelvat]

Almost a month has passed ...
This PR fixed #1143, please merge it.

[starius]

+1 for this.
Tony, can you rebase and merge it, please?

[tonytheodore]

Rebased and merged - apologies. Apart from running out of time, I messed up my git config with proxy settings...grrrr