github.mk: fix tag prefix with single v and pkg name <> project name
#1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonytheodore
force-pushed
the
tag-prefix
branch
from
cc4790d
to
934ad30
Compare
- box2d <> Box2D - glfw3 <> glfw
first target read can be affected by definitions in included files
|
Maybe this variant: more unified than: |
|
How do the cmake rule examples look? We could add |
|
I'll take those |
Actually, I'll leave them in - there's no functional change and they're already tested. This PR seems covers some more cases with GH_CONF, the odd single |
tonytheodore
changed the title
vv and pkg name <> project name
tonytheodore
added a commit
to tonytheodore/mxe
that referenced
this pull request
Apr 2, 2017
Use `.DEFAULT_GOAL` [special variable] instead of `.DEFAULT` [built-in target] as the latter depends on include order and can cause confusing behaviour. `LOCAL_PKG_LIST` was [broken] in mxe#1729 and this allows for any current `settings.mk` to work correctly. Should also fix mxe#1264 and mxe#1267 since MXE isn't going to include any other files that set this variable in a surprising way. [special variable]:https://www.gnu.org/software/make/manual/make.html#Special-Variables [built-in target]:https://www.gnu.org/software/make/manual/make.html#Special-Targets [broken]:mxe@1cf2afb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1728