Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix db-2-install-exe.patch #2186

Closed
wants to merge 1 commit into from
Closed

fix db-2-install-exe.patch #2186

wants to merge 1 commit into from

Conversation

DemonRx
Copy link

@DemonRx DemonRx commented Aug 19, 2018

Fixes db-2-install-exe.patch

Incorrect variable defined in

$(INSTALLER) $$i $(DESTDIR)$(bindir)/$$e; \

Should be $(INSTALLER) $$e to match with

e=$$i.exe; \

Make any edits as necessary for successful commit please. @starius @tonytheodore

@DemonRx DemonRx changed the title fix db-2-install.patch fix db-2-install-exe.patch Aug 19, 2018
@tonytheodore
Copy link
Member

That won't work for earlier gcc versions. I think a better fix is to remove the patch altogether and use the transform variable to fix the output name for gcc ≤ 7.

@DemonRx
Copy link
Author

DemonRx commented Aug 19, 2018

Alright, make it work :), I'll close this PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants