sdl_gfx: 64-bit support #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…conf is used in any other SDL_* package
…86_64 fixed in upstream trunk)
|
Thanks! Can you roll up your changes from https://gitorious.org/sdlgfx/asm into patch? |
|
I have a patch ready. I'll check with Andreas Schiffler how he thinks about shipping it in MXE. |
|
Seems like removing |
|
Thanks for the heads-up! |
|
OK, Andreas Schiffler didn't object, so #266 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I disabled 'mmx' buggy support in sdl_gfx, so it compiles on 64-bit (and doesn't crash on i386 - see below).
I also removed the 'autoreconf'iguration as everything compiled fine without.
Additional note: SDL_imagefilter.c, which uses MMX is actually rarely used, and was tested VC++. The GCC ASM version crashed due to incorrect use of popa/pusha instructions (the code didn't take the stack pointer change into account). I worked for 2 weeks on a fix using GCC intrinsics at https://gitorious.org/sdlgfx/asm/, fixing i386 and adding 64-bit support. The SDL_gfx maintainer took is for the upcoming SDL2_gfx, although there's no plan for SDL_gfx right now.