-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Coin3D #966
Add Coin3D #966
Conversation
@@ -33,6 +33,7 @@ | |||
"cimg": "1.6.3", | |||
"cmake": "3.0.2", | |||
"cminpack": "1.3.4", | |||
"coin": "3.1.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is updated by @MXEBot
Please squash 8889b3a |
Done |
I think name |
define $(PKG)_BUILD | ||
cd '$(1)' && ./configure \ | ||
$(MXE_CONFIGURE_OPTS) \ | ||
--disable-debug \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spaces and tabs mixture.
The package installs files |
Files created by package |
--without-zlib \ | ||
--without-bzip2 \ | ||
--without-x | ||
$(MAKE) -C '$(1)' -j 1 uninstall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you make uninstall
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied this from x264.mk, supposing there was a reason for this. I guess it can be omitted.
Please add a test executable using this library and add a command to build it. It is needed to check linking errors. |
I don't agree with the name coin3d, gentoo or opensuse call it "coin", so I think sticking to names in use is best. |
I'll set up a test, but I will be busy tomorrow, so please be patient. |
Agreed. |
No *.dll created for shared builds?
I imagine they use relative paths to locate the installation. We'd normally create a prefixed symlink |
By the way, it is a good check for build-pkg. |
Report only if the item installs .a See mxe#966 (comment)
Report only if the item installs .a See mxe#966 (comment)
I'm trying to add the dynamic library, but I get the following messages that aren't really clear to me:
Can someone shed some light on how to fix this properly? Thanks! |
Add shared / static linking of libraries that doesn't work yet, see #966
(This is correct since the DLLs aren't built correctly.) Remove link to coin-config since it's broken
OK, so two problems remain: Firstly, I had to remove the link of coin-config to
doesn't do the trick. So one would need to patch coin-config, I'm not sure if that's the way to go? Secondly, the DLLs are still not created as stated above. I'd be very grateful for any help or recommendations. |
No help for me? I don't know how to solve either of the two problems satisfactorily. The first one isn't really that much of an issue I guess. For the second one, I'm not sure what correct behavior would be, given that there are no .dll files for the mentioned libs. So should just the statically linked archive be included in creating the dll? |
Report only if the item installs .a See mxe#966 (comment)
This sounds like you'll have to set the libtool cache variables directly, look at exiv2 or portaudio:
Not sure what to do about this, most likely will just have to invoke it with the full path or use As an aside, this release looks very old, would it be better to use the latest development version? |
@tonytheodore Thanks for the hint, alas, that's not the issue. As for the version, I think 3.1.3 is fine. It is what all distributions I checked include, so I think it's good to have the same version that will be available by default. Also, while it's an old version, not that much has happened in the repository either. |
I found a workaround for a similar We normally enable most features of a package, could you take a look at that and open a new request? Thanks. |
@tonytheodore awesome, thank you so much! I will do that, I thought I read somewhere that the dependencies should be kept minimal, which was why I disabled everything not necessary. But I'll add them! |
No worries, We try to keep native requirements minimal to avoid doc building etc., but otherwise packages should enable as much as possible. |
OK, then one more question that isn't clear to me. Since autoconf will enable/disable things automatically based on what it finds, should I just not --disable things and let autoconf and thus the user decide based on what his MXE setup provides, or should the dependencies be listed explicitly, making it actually enable everything it can, but thereby possibly bloating more than the user might want? Edit: OK, coin actually does run time linking of all its dependencies, so it doesn't matter here. Still it's an interesting question for possible further packages. |
Ideally, explicit dependencies and |
This adds the Coin3D framework, a BSD licensed implementation of Open Inventor (http://www.openinventor.com/) to MXE..