Change operator-linebreak to before instead of after.

[sambev]

I am proposing that we change our operator line break to either before or just turning it off completely.

Current (after):

var fullHeight = borderTop +
                 innerHeight +
                 borderBottom;

This PR (before):

var fullHeight = borderTop
               + innerHeight
               + borderBottom;

I particularly like before much better with conditionals and terns:

if (someCondition
    || otherCondition) {
}

answer = everything
  ? 42
  : foo;


answer = everything ? 42
                    : 0

As I said before, I would also be okay with removing any before or after rule entirely. I mostly just hate being forced to use after, especially when conditionals and terns are longer and I am using split pane views with more "real life" code examples:

😢 (Sam with after)

const transactions = this.props.displayChildAsParent ?
  TransactionUtils.filterOutParentsOfSplits(this.props.transactions) :
  TransactionUtils.filterOutChildrenOfSplits(this.props.transactions);

In this paritcular case, the ? : || && characters can get cut off in the current pane, forcing me to horizontally scroll to see what is going on

😄 (Sam with before)

const transactions = this.props.displayChildAsParent
  ? TransactionUtils.filterOutParentsOfSplits(this.props.transactions)
  : TransactionUtils.filterOutChildrenOfSplits(this.props.transactions);

With before, the operators are always visible and aligned with each other.

[lukeschunk]

i think i prefer after still, but not extremely opposed

[lukeschunk]

also thanks for the good write up 🏀

[paniclater]

I don't have a preference here.

[paniclater]

As in, I'm good either way.

[cerinman]

Hmm, I lean toward before but I'm good either way

[jtanner]

I'm leaning toward before as well.

[redperk]

I think I'm leaning to before as well, but I'm fine either way

[phantomxc]

before

[jtanner]