Skip to content

Commit

Permalink
fix eslint rules
Browse files Browse the repository at this point in the history
  • Loading branch information
jmo committed Oct 15, 2016
1 parent ed3d012 commit 5dc5639
Show file tree
Hide file tree
Showing 2 changed files with 182 additions and 47 deletions.
170 changes: 150 additions & 20 deletions .eslintrc.js
View file
Expand Up @@ -6,25 +6,155 @@ module.exports = {
},
"extends": "eslint:recommended",
"rules": {
"no-multi-spaces": "error",
"no-var": [
"error"
],
"indent": [
"error",
2
],
"linebreak-style": [
"error",
"unix"
],
"quotes": [
"error",
"single"
],
"semi": [
"error",
"always"
]
"accessor-pairs": 0,
"array-bracket-spacing": [2, "never"],
"arrow-spacing": [2, {"before": true, "after": true }],
"block-scoped-var": 0,
"brace-style": 2,
"camelcase": 0,
"comma-dangle": 2,
"comma-spacing": 2,
"comma-style": 2,
"computed-property-spacing": 2,
"consistent-return": 2,
"consistent-this": 0,
"constructor-super": 2,
"curly": 0,
"default-case": 0,
"dot-location": [2, "property"],
"dot-notation": 0,
"eol-last": 0,
"eqeqeq": [2, "smart"],
"func-names": 0,
"func-style": 0,
"generator-star-spacing": [2, {"before": false, "after": true}],
"guard-for-in": 2,
"handle-callback-err": 0,
"indent": [2, 2, {"SwitchCase": 1}],
"jsx-quotes": [2, "prefer-single"],
"key-spacing": [2, {"beforeColon": false, "afterColon": true}],
"keyword-spacing": 2,
"linebreak-style": 2,
"lines-around-comment": [2, {"beforeBlockComment": true, "beforeLineComment": false}],
"max-nested-callbacks": [2, 3],
"new-cap": 0,
"new-parens": 2,
"newline-after-var": [2, "always"],
"no-alert": 2,
"no-array-constructor": 2,
"no-caller": 2,
"no-catch-shadow": 0,
"no-confusing-arrow": [2, {"allowParens": true}],
"no-console": [2, {"allow": ["warn", "error"]}],
"no-constant-condition": 2,
"no-continue": 2,
"no-debugger": 2,
"no-delete-var": 2,
"no-div-regex": 2,
"no-dupe-args": 2,
"no-dupe-keys": 2,
"no-duplicate-case": 2,
"no-else-return": 0,
"no-empty": 2,
"no-empty-character-class": 2,
"no-eq-null": 2,
"no-eval": 2,
"no-ex-assign": 2,
"no-extend-native": 2,
"no-extra-bind": 0,
"no-extra-boolean-cast": 2,
"no-extra-parens": 0,
"no-extra-semi": 2,
"no-fallthrough": 2,
"no-floating-decimal": 2,
"no-implied-eval": 2,
"no-inline-comments": 0,
"no-inner-declarations": 0,
"no-invalid-regexp": 2,
"no-irregular-whitespace": 2,
"no-iterator": 2,
"no-label-var": 2,
"no-labels": 2,
"no-lone-blocks": 2,
"no-lonely-if": 2,
"no-loop-func": 2,
"no-magic-numbers": 0,
"no-mixed-requires": 2,
"no-mixed-spaces-and-tabs": 2,
"no-multi-spaces": 2,
"no-multi-str": 2,
"no-multiple-empty-lines": 2,
"no-native-reassign": 2,
"no-negated-in-lhs": 0,
"no-nested-ternary": 2,
"no-new": 2,
"no-new-func": 2,
"no-new-object": 2,
"no-new-require": 2,
"no-new-wrappers": 2,
"no-obj-calls": 0,
"no-octal": 2,
"no-octal-escape": 2,
"no-param-reassign": 2,
"no-path-concat": 0,
"no-process-env": 2,
"no-process-exit": 0,
"no-proto": 2,
"no-redeclare": 2,
"no-regex-spaces": 2,
"no-reserved-keys": 0,
"no-restricted-modules": 0,
"no-script-url": 2,
"no-self-compare": 2,
"no-sequences": 2,
"no-shadow": 0,
"no-shadow-restricted-names": 2,
"no-spaced-func": 2,
"no-sparse-arrays": 2,
"no-sync": 0,
"no-ternary": 0,
"no-this-before-super": 2,
"no-throw-literal": 2,
"no-trailing-spaces": 2,
"no-undef": 0,
"no-undef-init": 2,
"no-undefined": 2,
"no-underscore-dangle": 0,
"no-unexpected-multiline": 2,
"no-unneeded-ternary": 2,
"no-unreachable": 2,
"no-unused-expressions": 2,
"no-unused-vars": 2,
"no-use-before-define": 0,
"no-var": 2,
"no-void": 2,
"no-warning-comments": 0,
"no-with": 2,
"object-curly-spacing": [2, "always"],
"object-shorthand": [2, "always"],
"one-var": [2, "never"],
"operator-assignment": [2, "always"],
"operator-linebreak": [2, "after"],
"padded-blocks": [2, "never"],
"prefer-const": 2,
"quote-props": 0,
"quotes": [2, "single", "avoid-escape"],
"radix": 2,
"semi": [2, "always"],
"semi-spacing": [2, {"before": false, "after": true}],
"sort-vars": 2,
"space-before-blocks": 2,
"space-before-function-paren": 2,
"space-in-parens": [2, "never"],
"space-infix-ops": 2,
"space-unary-ops": 2,
"spaced-comment": 0,
"use-isnan": 2,
"valid-jsdoc": 0,
"valid-typeof": 0,
"vars-on-top": 2,
"wrap-iife": 2,
"wrap-regex": 2,
"yoda": 2
}
};
59 changes: 32 additions & 27 deletions index.js
View file
Expand Up @@ -146,11 +146,10 @@ Atrium.endpoints = [
url: '/users/:userGuid/transactions/:transactionGuid',
clientMethod: 'readTransaction',
key: 'transaction'
},

}
];

Atrium.Client = function(apiKey, clientID, url) {
Atrium.Client = function (apiKey, clientID, url) {
if (!clientID) {
throw new Error('Missing client ID');
}
Expand All @@ -169,7 +168,7 @@ Atrium.Client = function(apiKey, clientID, url) {
};

//Fetch utility
Atrium.Client.prototype._fetchUtility = function(endpoint, method, params = null) {
Atrium.Client.prototype._fetchUtility = function (endpoint, method, params = null) {
const body = params ? JSON.stringify(params) : null;

return (fetch(this.url + '/' + endpoint, {
Expand Down Expand Up @@ -198,100 +197,106 @@ Atrium.Client.prototype._fetchUtility = function(endpoint, method, params = null
};

//Users
Atrium.Client.prototype.createUser = function(request) {
Atrium.Client.prototype.createUser = function (request) {
return this._fetchUtility('users', 'POST', request.body);
};

Atrium.Client.prototype.readUser = function(request) {
Atrium.Client.prototype.readUser = function (request) {
return this._fetchUtility('users/' + request.params.userGuid, 'GET');
};

Atrium.Client.prototype.updateUser = function(request) {
const user = Object.assign({}, request.body.user, { guid: undefined, id: undefined, logged_in_at: undefined });
Atrium.Client.prototype.updateUser = function (request) {
const user = Object.assign({}, request.body.user);

delete user.guid;
delete user.id;
delete user.logged_in_at;

console.log('user', user);

return this._fetchUtility('users/' + request.body.user.guid, 'PUT', { user });
};

Atrium.Client.prototype.deleteUser = function(request) {
Atrium.Client.prototype.deleteUser = function (request) {
return this._fetchUtility('users/' + request.params.userGuid, 'DELETE');
};

//Institutions
Atrium.Client.prototype.listInstitutions = function() {
Atrium.Client.prototype.listInstitutions = function () {
return this._fetchUtility('institutions', 'GET');
};

//Credentials
//Fix Institution param
Atrium.Client.prototype.listCredentials = function(request) {
Atrium.Client.prototype.listCredentials = function (request) {
return this._fetchUtility(`institutions/${request.params.institutionCode}/credentials`, 'GET');
};

//Members
//Fix pagination error
Atrium.Client.prototype.listMembers = function(request) {
Atrium.Client.prototype.listMembers = function (request) {
return this._fetchUtility(`users/${request.params.userGuid}/members`, 'GET');
};

Atrium.Client.prototype.createMember = function(request) {
Atrium.Client.prototype.createMember = function (request) {
return this._fetchUtility(`users/${request.params.userGuid}/members`, 'POST', request.body);
};

Atrium.Client.prototype.readMember = function(request) {
Atrium.Client.prototype.readMember = function (request) {
return this._fetchUtility(`users/${request.params.userGuid}/members/${request.params.memberGuid}`, 'GET');
};

Atrium.Client.prototype.updateMember = function(request) {
Atrium.Client.prototype.updateMember = function (request) {
return this._fetchUtility(`users/${request.params.userGuid}/members/${request.params.memberGuid}`, 'PUT', request.body);
};

Atrium.Client.prototype.deleteMember = function(request) {
Atrium.Client.prototype.deleteMember = function (request) {
return this._fetchUtility(`users/${request.params.userGuid}/members/${request.params.memberGuid}`, 'DELETE');
};

Atrium.Client.prototype.aggregateMember = function(request) {
Atrium.Client.prototype.aggregateMember = function (request) {
return this._fetchUtility(`users/${request.params.userGuid}/members/${request.params.memberGuid}/aggregate`, 'POST');
};

Atrium.Client.prototype.resumeMemberAggregation = function(request) {
Atrium.Client.prototype.resumeMemberAggregation = function (request) {
return this._fetchUtility(`users/${request.params.userGuid}/members/${request.params.memberGuid}/resume`, 'PUT', request.body);
};

Atrium.Client.prototype.listMemberChallenges = function(request) {
Atrium.Client.prototype.listMemberChallenges = function (request) {
return this._fetchUtility(`users/${request.params.userGuid}/members/${request.params.memberGuid}/challenges`, 'GET');
};

Atrium.Client.prototype.checkMemberStatus = function(request) {
Atrium.Client.prototype.checkMemberStatus = function (request) {
return this._fetchUtility(`users/${request.params.userGuid}/members/${request.params.memberGuid}/status`, 'GET');
};

//Accounts
Atrium.Client.prototype.listAccounts = function(request) {
Atrium.Client.prototype.listAccounts = function (request) {
return this._fetchUtility(`users/${request.params.userGuid}/accounts`, 'GET');
};

Atrium.Client.prototype.readAccount = function(request) {
Atrium.Client.prototype.readAccount = function (request) {
return this._fetchUtility(`users/${request.params.userGuid}/accounts/${request.params.accountGuid}`, 'GET');
};

Atrium.Client.prototype.listAccountTransactions = function(request) {
Atrium.Client.prototype.listAccountTransactions = function (request) {
return this._fetchUtility(`users/${request.params.userGuid}/accounts/${request.params.accountGuid}/transactions`, 'GET');
};

//Holdings
Atrium.Client.prototype.listHoldings = function(request) {
Atrium.Client.prototype.listHoldings = function (request) {
return this._fetchUtility(`users/${request.params.userGuid}/holdings`, 'GET');
};

Atrium.Client.prototype.readHolding = function(request) {
Atrium.Client.prototype.readHolding = function (request) {
return this._fetchUtility(`users/${request.params.userGuid}/holdings/${request.params.holdingGuid}`, 'GET');
};

//Transactions
Atrium.Client.prototype.listTransactions = function(request) {
Atrium.Client.prototype.listTransactions = function (request) {
return this._fetchUtility(`users/${request.params.userGuid}/transactions`, 'GET');
};

Atrium.Client.prototype.readTransaction = function(request) {
Atrium.Client.prototype.readTransaction = function (request) {
return this._fetchUtility(`users/${request.params.userGuid}/transactions/${request.params.transactionGuid}`, 'GET');
};

0 comments on commit 5dc5639

Please sign in to comment.