Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fowles/tooltip] => [master] Remove Boxshadow in Dark Mode #79

Merged
merged 4 commits into from
Sep 29, 2021

Conversation

jsfowles
Copy link
Collaborator

Description of work

Added Tooltip: 'none', to the dark boxShadow design token.

QA

Used npm link to verify there is no longer a shadow on dark, but remains on light.

Screen Shots

Dark:
Screen Shot 2021-09-28 at 11 08 35 AM

Light:
Screen Shot 2021-09-28 at 11 08 43 AM

@jgerlach
Copy link
Collaborator

You will need to update the changelog and the package.json version. Since we don't use Lerna in this repo we handle that manually.

@jsfowles
Copy link
Collaborator Author

@jgerlach - I've updated the version and added a changelog entry.

@jgerlach
Copy link
Collaborator

Looks good to me. I'll merge and publish it.

@jgerlach jgerlach merged commit 6da184d into master Sep 29, 2021
@jgerlach jgerlach deleted the fowles/tooltip-box-shadow-dark branch September 29, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants