-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Luke/use glamor in button #713
Conversation
src/components/Button.js
Outdated
@@ -66,9 +67,9 @@ class Button extends React.Component { | |||
|
|||
return ( | |||
<button | |||
className={css(Object.assign({}, styles.component, styles[this.props.type], style))} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know the object assign was already there but could you switch it object spread while you're here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -248,4 +249,4 @@ class Button extends React.Component { | |||
}; | |||
} | |||
|
|||
module.exports = Radium(Button); | |||
module.exports = Button; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think that removing Radium
will fix the bug you are experiencing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i do
This PR