feat: relax trait bounds on map_codec
#11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Friendly ping @mxinden. |
mxinden
reviewed
Oct 10, 2023
I'd like this to just merge it together with #9 so I figured only one of them needs to bump the version. |
mxinden
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These trait-bounds are unnecessarily restrictive and don't need to be on this function. If the user maps to a type that doesn't implement
Encoder+Decoder, they end up with an unusable type. However, this may sometimes be desired.For example, in libp2p/rust-libp2p#4548, mapping the codec is a fallible function that returns a tuple where only one part is the codec. This is hard to express in a general way which is why #10 got closed.
However, if we relax these trait-bounds, the codec can be mapped to an
Option<T>and extracted viamem::replace.