Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add context matcher and export types #39

Merged
merged 5 commits into from
Sep 30, 2023

Conversation

jacobmolby
Copy link
Contributor

Hi, this PR adds a new option translationContextMatcher.

It's purpose is to not split every key up by the contextSeperator, but only remove context suffixes.

In my code base it made the result of the CLI unusable since the keys are snaked case.

Example:

{
   "press_to_deselect": "..."
}

The translationContextMatcher defaults to a regex that should capture the context used by i18n-next in the various versions of their JSON Format. I wasn't sure if anything else existed out there, so I made it configurable.

Besides that I've moved some of the documentation from the README into the RunOptions interface and exported it, allowing users to have autocomplete when creating their config.

I also moved this part [...matchKeysSet].toString() out of the for loop, since it seemed unnecessary to compute the string every iteration.

Let me know if you have any comments.

@mxmvshnvsk mxmvshnvsk merged commit bee1b97 into mxmvshnvsk:main Sep 30, 2023
@mxmvshnvsk
Copy link
Owner

Hi, thanks for your PR, it's good feature. Already in release 0.15.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants