Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding Subtitles and Captions #162

Closed
ticky opened this issue Aug 11, 2020 · 0 comments · Fixed by #163
Closed

Embedding Subtitles and Captions #162

ticky opened this issue Aug 11, 2020 · 0 comments · Fixed by #163

Comments

@ticky
Copy link
Contributor

ticky commented Aug 11, 2020

I’d love to be able to include subtitles and captions (where available) in the video files. I’ve confirmed that Apple Podcasts supports these captions (it appears to support all the same formats the usual iOS video player does), and it’s likely that other players would support some, or many, subtitle formats in the resultant mp4 videos.

It’s possible to add something like --write-sub --write-auto-sub --embed-subs to the youtube-dl command to allow for this, which will download either the manually-supplied, or automatic captions for youtube videos.

ticky added a commit to ticky/podsync that referenced this issue Aug 11, 2020
This allows inserting arbitrary extra arguments into the youtube-dl command-line within each podcast feed entry. This allows, for example, requesting that youtube-dl embed subtitles and captions into the video file, or configuring additional postprocessor arguments.

No effort has been made to make sure no incompatible arguments are provided, with the expectation that the end-user will understand what's possible, and that this is an option expressly for advanced users.

This would fix mxpv#162,and theoretically also mxpv#136!
@mxpv mxpv closed this as completed in #163 Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant