Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually triggered debug documentation not working #154

Closed
uvtrip opened this issue Feb 26, 2023 · 3 comments
Closed

Manually triggered debug documentation not working #154

uvtrip opened this issue Feb 26, 2023 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@uvtrip
Copy link

uvtrip commented Feb 26, 2023

in your Manually triggered debug you mention:

if: ${{ github.event_name == 'workflow_dispatch' && inputs.debug_enabled }}

it should be:

if: ${{ github.event_name == 'workflow_dispatch' && inputs.debug_enabled == 'true'}}
as all boolean inputs are treated as strings not boolean

@mxschmitt mxschmitt added the documentation Improvements or additions to documentation label May 14, 2023
maawoo added a commit to maawoo/ceos-ard-spec-tables that referenced this issue May 30, 2023
@YuviGold
Copy link

It was actually fixed with #123 and #129

The information in the inputs context and github.event.inputs context is identical except that the inputs context preserves Boolean values as Booleans instead of converting them to strings.

ref https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#providing-inputs

Unfortunately I had the exact same issue and it took me hours to tell the difference.
Due to its confusing usage, I'd suggest adding a clarification regarding the correct usage @mxschmitt

@KrisThielemans
Copy link

it's unclear to me what the correct syntax is now. None of them seem to work for me (but then again, commenting the if statement didn't work either!)

@uvtrip
Copy link
Author

uvtrip commented Nov 23, 2023

@YuviGold you are right, managed to handle it
thx !

@uvtrip uvtrip closed this as completed Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants