chore: use no network during mvn compile (#191)

Fixes #189

internal/worker/files.go

@@ -4,21 +4,23 @@ import (
 	"fmt"
 	"log"
 	"os"
+	"path/filepath"
 	"sync"
 
 	"github.com/fsnotify/fsnotify"
 )
 
 type filesCollector struct {
-	dir     string
-	done    chan bool
-	watcher *fsnotify.Watcher
+	dir            string
+	ignorePatterns []string
+	done           chan bool
+	watcher        *fsnotify.Watcher
 
 	filesMu sync.Mutex
 	files   []string
 }
 
-func newFilesCollector(dir string) (*filesCollector, error) {
+func newFilesCollector(dir string, ignorePatterns []string) (*filesCollector, error) {
 	watcher, err := fsnotify.NewWatcher()
 	if err != nil {
 		return nil, fmt.Errorf("could not create new fs watcher: %w", err)
@@ -27,10 +29,11 @@ func newFilesCollector(dir string) (*filesCollector, error) {
 		return nil, fmt.Errorf("could not add dir to watcher: %w", err)
 	}
 	fw := &filesCollector{
-		done:    make(chan bool),
-		watcher: watcher,
-		dir:     dir,
-		files:   []string{},
+		done:           make(chan bool),
+		watcher:        watcher,
+		dir:            dir,
+		ignorePatterns: ignorePatterns,
+		files:          []string{},
 	}
 	go fw.watch()
 	return fw, nil
@@ -69,6 +72,16 @@ func (fw *filesCollector) watch() {
 }
 
 func (fw *filesCollector) consumeCreateEvent(event fsnotify.Event) error {
+	for _, ignorePattern := range fw.ignorePatterns {
+		matched, err := filepath.Match(ignorePattern, event.Name)
+		if err != nil {
+			return fmt.Errorf("could not match pattern: %w", err)
+		}
+		if matched {
+			return nil
+		}
+	}
+
 	fi, err := os.Stat(event.Name)
 	if err != nil {
 		return fmt.Errorf("could not stat: %w", err)
@@ -77,10 +90,11 @@ func (fw *filesCollector) consumeCreateEvent(event fsnotify.Event) error {
 		if err := fw.watcher.Add(event.Name); err != nil {
 			return fmt.Errorf("could not add folder recursivelyt: %w", err)
 		}
-	} else {
-		fw.filesMu.Lock()
-		fw.files = append(fw.files, event.Name)
-		fw.filesMu.Unlock()
+		return nil
 	}
+
+	fw.filesMu.Lock()
+	fw.files = append(fw.files, event.Name)
+	fw.filesMu.Unlock()
 	return nil
 }

internal/worker/worker.go

@@ -73,7 +73,7 @@ func (w *Worker) ExecCommand(name string, args ...string) error {
 	if err != nil {
 		return fmt.Errorf("could not command lookup path: %w", err)
 	}
-	collector, err := newFilesCollector(w.tmpDir)
+	collector, err := newFilesCollector(w.tmpDir, w.options.IgnoreFilePatterns)
 	if err != nil {
 		return fmt.Errorf("could not create file collector: %w", err)
 	}
@@ -191,6 +191,7 @@ type WorkerExectionOptions struct {
 	Handler            executionHandler
 	ExecutionDirectory string
 	TransformOutput    func(output string) string
+	IgnoreFilePatterns []string
 }
 
 func NewWorker(options *WorkerExectionOptions) *Worker {

worker-java/Dockerfile

@@ -25,9 +25,7 @@ RUN mkdir /home/pwuser/project/
 COPY worker-java/pom.xml /home/pwuser/project/
 
 RUN cd /home/pwuser/project/ && \
-    mvn install
-
-COPY worker-java/settings.xml /home/pwuser/.m2/
+    mvn dependency:resolve-plugins dependency:go-offline
 
 COPY --from=builder /app /app
 

worker-java/main.go

@@ -26,7 +26,7 @@ func handler(w *worker.Worker, code string) error {
 	if err := os.WriteFile(filepath.Join(basePath, fmt.Sprintf("%s.java", className)), []byte(code), 0644); err != nil {
 		return fmt.Errorf("could not write Java source files: %v", err)
 	}
-	return w.ExecCommand("mvn", "compile", "exec:java", "-q", "-D", "jdk.module.illegalAccess=deny", "-D", fmt.Sprintf("exec.mainClass=org.example.%s", className))
+	return w.ExecCommand("mvn", "compile", "exec:java", "-q", "--offline", "-D", fmt.Sprintf("exec.mainClass=org.example.%s", className))
 }
 
 const NEW_LINE_SEPARATOR = "\n"
@@ -61,5 +61,6 @@ func main() {
 		Handler:            handler,
 		ExecutionDirectory: projectDir,
 		TransformOutput:    transformOutput,
+		IgnoreFilePatterns: []string{filepath.Join(projectDir, "target", "**")},
 	}).Run()
 }

worker-java/pom.xml

@@ -19,6 +19,11 @@
     </dependencies>
     <build>
         <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-dependency-plugin</artifactId>
+                <version>3.1.1</version>
+            </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>