Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the logos be a sprite or font-based #84

Closed
bfad opened this issue Sep 16, 2017 · 3 comments
Closed

Have the logos be a sprite or font-based #84

bfad opened this issue Sep 16, 2017 · 3 comments

Comments

@bfad
Copy link

bfad commented Sep 16, 2017

I think it would be beneficial to have the logos be in a single sprite image or a single font. It would add an extra HTTP request, but at least it would be cacheable. Subsequent requests wouldn't have to make the additional request, and since the SVG code isn't inline, that means a reduction in bandwidth on those requests as well.

@bfad
Copy link
Author

bfad commented Sep 16, 2017

Or, maybe move the SVG data into a CSS background-image: url("data:image/svg+xml;...) since the CSS will be cached?

@sparr
Copy link
Contributor

sparr commented Jan 4, 2019

Is this still relevant? SVG appears to be inline now.

@mxstbr
Copy link
Owner

mxstbr commented Jan 7, 2019

I think this is out of the scope of this project, as it is a small enhancement that might or might not work out as a benefit when tested with your actual production users. Will close this for now, thanks for starting this discussion @bfad!

@mxstbr mxstbr closed this as completed Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants