Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http]: Investigate why some users got generic TLS error #64

Closed
diamante0018 opened this issue Jan 7, 2024 · 1 comment
Closed

[http]: Investigate why some users got generic TLS error #64

diamante0018 opened this issue Jan 7, 2024 · 1 comment

Comments

@diamante0018
Copy link
Collaborator

Even though we switched the CDN to plain HTTP protocol, that should be regarded as a temporary solution.
It's clear to me there is something very fishy going on with the dependencies this project uses for HTTPs queries.

Ideally, we would need to find a library that can be tweaked like Curl on C++

curl_easy_setopt(curl, CURLOPT_SSL_VERIFYPEER, 0L);
curl_easy_setopt(curl, CURLOPT_SSL_VERIFYHOST, 0L);

https://curl.se/libcurl/c/CURLOPT_PROXY_SSL_VERIFYHOST.html

I suspect that when the old XLabs launcher used these settings no one ever had the issue the AW launcher has.

Any HTTPS/TLS library in Rust that can promise to tweak these settings (equivalent from Curl) should be used and tried so we can go back to HTTPS.

@diamante0018 diamante0018 changed the title [http]: Investigate why TLS failed to verify for some users [http]: Investigate why some users got generic TLS error Jan 7, 2024
mxve added a commit that referenced this issue Feb 20, 2024
close #43
Should also help to either resolve or at least investigate seemingly random TLS & IO errors #64 #77
@diamante0018
Copy link
Collaborator Author

Seems to be related to the library we used

@diamante0018 diamante0018 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant