Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cjsx? #3

Closed
KyleAMathews opened this issue Jun 5, 2014 · 7 comments
Closed

Support cjsx? #3

KyleAMathews opened this issue Jun 5, 2014 · 7 comments

Comments

@KyleAMathews
Copy link

https://github.com/jsdf/coffee-react-transform

@mxw
Copy link
Owner

mxw commented Jun 5, 2014

No plans to add support for this myself. If you want to, definitely make a pull request—otherwise this is a wontfix.

@KyleAMathews
Copy link
Author

Actually this should be its own project which I can jump on.

I've never done anything with vim plugins before. I'm assuming I can mostly just copy what you've done here? Any potential gotchas I should look for while doing the modifications?

@mxw
Copy link
Owner

mxw commented Jun 7, 2014

Sure, that works too. This is a pretty simple bundle and there aren't many tricks, but you should make sure you know enough Vimscript and vim syntax rules to read the Coffeescript syntax files and understand where to put the glue. The indenting is a bit more finnicky and depends a tad on how Coffeescript indenting works, so it may be less copypasta-able than the syntax.

It's hard to get totally right without picking up Vimscript, but if you're willing to do that, it shouldn't be too troublesome.

@mxw mxw closed this as completed Jun 7, 2014
@mtscout6
Copy link

@KyleAMathews Have you started up on this if not I plan to here over the next few days?

@KyleAMathews
Copy link
Author

I haven't. Feel free to jump on it. Ping me when you have something working and I'll test it.

@mtscout6
Copy link

Still working on it, but the repo is created: https://github.com/mtscout6/vim-cjsx

@mtscout6
Copy link

I think i've got the syntax highlighting looking good now if you want to take a look. I'm not planning to tackle the indentation right now, but I'll take a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants