use gSP instead of gSSP #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/my-covid-story/www/3itHwKT3aqGEmiohPby9tTt48b1u |
mwickett
commented
Apr 19, 2021
Comment on lines
-16
to
22
| name='description' | ||
| content='Every covid number has a story which deserves to be shared' | ||
| name="description" | ||
| content="Every covid number has a story which deserves to be shared" | ||
| /> | ||
| <link rel='icon' href='/favicon.ico' /> | ||
| <link rel="icon" href="/favicon.ico" /> | ||
| </Head> | ||
| <div className={landing.background} /> | ||
| <main className={landing.main}> |
There was a problem hiding this comment.
I need to setup a format command for lint-staged/husky.
mwickett
commented
Apr 19, 2021
Comment on lines
-79
to
+82
| export async function getServerSideProps() { | ||
| export async function getStaticProps() { |
There was a problem hiding this comment.
This is the only non-formatting change.
silent1mezzo
approved these changes
Apr 19, 2021
|
Yeah, absolutely. Let's leave it to @davesteinberg as he'll be working on the homepage avec feed etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to
getStaticPropson the homepage. We'll add revalidate as part of the full homepage buildout.