Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add social share buttons #85

Merged
merged 5 commits into from
Apr 24, 2021
Merged

Add social share buttons #85

merged 5 commits into from
Apr 24, 2021

Conversation

silent1mezzo
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Apr 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/my-covid-story/www/8vMnKBHPfYfLExRP3Ghj5GfSpNXd
✅ Preview: https://www-git-amsocial-my-covid-story.vercel.app

@silent1mezzo silent1mezzo marked this pull request as draft April 24, 2021 02:55
Copy link
Contributor

@mwickett mwickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor question about the minHeight thing, but not blocking IMO.

Comment on lines +11 to +13
// TODO: This is gross, how can this be done better?
const minHeight = 2000

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Does this need to be a const - can it just be passed in as a prop where it's used?

@silent1mezzo silent1mezzo merged commit 91949cf into main Apr 24, 2021
@silent1mezzo silent1mezzo deleted the am.social branch April 24, 2021 21:35
@silent1mezzo silent1mezzo mentioned this pull request Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants