Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

footer clashes with side menu in small windows #1

Open
lukeocodes opened this issue Sep 12, 2018 · 10 comments
Open

footer clashes with side menu in small windows #1

lukeocodes opened this issue Sep 12, 2018 · 10 comments
Labels
beginner An issue intended to be fixed by a beginner to contributions or development. bug Something isn't working first-timers-only An issue intended to be fixed by a first time contributor. good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed up-for-grabs Issue for a new contributor. Waiting for someone to claim.

Comments

@lukeocodes
Copy link
Contributor

Describe the bug
When we view any page on this site in a small browser window, the footer will clash with the side menu

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://my-first-pr.github.io
  2. Resize the window small enough for the error to occur.

Expected behavior
The footer should clash with the side, it should wrap or go off the page to scroll to.

Screenshots
screen shot 2018-09-12 at 10 45 37

Desktop (please complete the following information):

  • OS: macOS High Sierra (blergh)
  • Browser: Chrome
  • Version: 68.0.3440.106

Additional context
Add any other context about the problem here.
@lukeocodes lukeocodes added bug Something isn't working good first issue Good for newcomers first-timers-only An issue intended to be fixed by a first time contributor. help wanted Extra attention is needed up-for-grabs Issue for a new contributor. Waiting for someone to claim. beginner An issue intended to be fixed by a beginner to contributions or development. labels Sep 12, 2018
@maciejmyslinski
Copy link

can't see any css file in the repo 😞

@lukeocodes
Copy link
Contributor Author

The site is using the minimal jekyll theme from github pages. The readme for this theme has some instructions on providing a custom CSS file to be able to make stylesheet changes.

https://github.com/pages-themes/minimal/blob/master/README.md

@agent1red
Copy link

I know how to fix this but I can't figure out how to add a stylesheet per the instructions. I have an SCSS file on my work environment but the HTML page renders without any styling in my localhost

@lukeocodes
Copy link
Contributor Author

Can I just confirm you've followed the steps to setting up a GitHub pages site locally?

@Nelson-Chinedu
Copy link

hey @lukeoliff is the issue still open

@lukeocodes
Copy link
Contributor Author

@Nelson-Chinedu yeh :)

@phatbhoy67 phatbhoy67 mentioned this issue Dec 4, 2018
Open
@NikithaNadig
Copy link

Hey can I work on this?

@lukeocodes
Copy link
Contributor Author

lukeocodes commented Jan 31, 2019 •
edited
Loading

Sure :D But check #10 first, sorry I haven't got around to merging it yet.

@pawgrmr
Copy link

pawgrmr commented Feb 8, 2019

Hi there, has this issue been resolved? I noticed a PR is pending approval..

@MrRohit-01
Copy link

Can i work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner An issue intended to be fixed by a beginner to contributions or development. bug Something isn't working first-timers-only An issue intended to be fixed by a first time contributor. good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed up-for-grabs Issue for a new contributor. Waiting for someone to claim.
Milestone
No milestone
Development

No branches or pull requests
7 participants
@lukeocodes @maciejmyslinski @agent1red @Nelson-Chinedu @pawgrmr @NikithaNadig @MrRohit-01