Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

footer clashes with side menu in small windows #1

Open
lukeocodes opened this Issue Sep 12, 2018 · 9 comments

Comments

6 participants
@lukeocodes
Copy link
Contributor

lukeocodes commented Sep 12, 2018

Describe the bug
When we view any page on this site in a small browser window, the footer will clash with the side menu

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://my-first-pr.github.io
  2. Resize the window small enough for the error to occur.

Expected behavior
The footer should clash with the side, it should wrap or go off the page to scroll to.

Screenshots
screen shot 2018-09-12 at 10 45 37

Desktop (please complete the following information):

  • OS: macOS High Sierra (blergh)
  • Browser: Chrome
  • Version: 68.0.3440.106

Additional context
Add any other context about the problem here.

@maciejmyslinski

This comment has been minimized.

Copy link

maciejmyslinski commented Sep 17, 2018

can't see any css file in the repo 😞

@lukeocodes

This comment has been minimized.

Copy link
Contributor Author

lukeocodes commented Sep 18, 2018

The site is using the minimal jekyll theme from github pages. The readme for this theme has some instructions on providing a custom CSS file to be able to make stylesheet changes.

https://github.com/pages-themes/minimal/blob/master/README.md

@agent1red

This comment has been minimized.

Copy link

agent1red commented Sep 22, 2018

I know how to fix this but I can't figure out how to add a stylesheet per the instructions. I have an SCSS file on my work environment but the HTML page renders without any styling in my localhost

@lukeocodes

This comment has been minimized.

Copy link
Contributor Author

lukeocodes commented Sep 24, 2018

Can I just confirm you've followed the steps to setting up a GitHub pages site locally?

@Nelson-Chinedu

This comment has been minimized.

Copy link

Nelson-Chinedu commented Oct 1, 2018

hey @lukeoliff is the issue still open

@lukeocodes

This comment has been minimized.

Copy link
Contributor Author

lukeocodes commented Oct 2, 2018

@NikithaNadig

This comment has been minimized.

Copy link

NikithaNadig commented Jan 25, 2019

Hey can I work on this?

@lukeocodes

This comment has been minimized.

Copy link
Contributor Author

lukeocodes commented Jan 31, 2019

Sure :D But check #10 first, sorry I haven't got around to merging it yet.

@pawgrmr

This comment has been minimized.

Copy link

pawgrmr commented Feb 8, 2019

Hi there, has this issue been resolved? I noticed a PR is pending approval..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.