Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PATTERN_LOG_ENDING to be compatible with scrapy-fieldstats #17

Merged
merged 3 commits into from
Aug 21, 2019

Conversation

my8100
Copy link
Owner

@my8100 my8100 commented Aug 21, 2019

Add LATEST_SCRAPE_ITEM_PATTERN for extracting latest_scrape and latest_item.

Add LATEST_SCRAPE_ITEM_PATTERN for extracting latest_scrape and latest_item
@pep8speaks
Copy link

pep8speaks commented Aug 21, 2019

Hello @my8100! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 81:42: E127 continuation line over-indented for visual indent
Line 107:5: E116 unexpected indentation (comment)
Line 108:9: E116 unexpected indentation (comment)
Line 109:9: E116 unexpected indentation (comment)
Line 110:5: E116 unexpected indentation (comment)
Line 111:5: E116 unexpected indentation (comment)
Line 112:5: E116 unexpected indentation (comment)
Line 113:5: E116 unexpected indentation (comment)
Line 114:5: E116 unexpected indentation (comment)
Line 121:21: E116 unexpected indentation (comment)

Comment last updated at 2019-08-21 09:44:50 UTC

@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #17 into master will increase coverage by 0.51%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   87.41%   87.92%   +0.51%     
==========================================
  Files           9        9              
  Lines         898      903       +5     
==========================================
+ Hits          785      794       +9     
+ Misses        113      109       -4
Impacted Files Coverage Δ
logparser/scrapylogparser.py 98.3% <100%> (+0.05%) ⬆️
logparser/logparser.py 95.6% <100%> (ø) ⬆️
logparser/common.py 100% <100%> (+4.21%) ⬆️

@my8100 my8100 merged commit 62c0451 into master Aug 21, 2019
@my8100 my8100 deleted the fit_scrapy_fieldstats branch August 21, 2019 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants