Export binding versions as separate major and minor integers

my8bird · Feb 26, 2012 · 8869113 · 8869113
1 parent 14e8b07
commit 8869113
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/coffee/index.coffee b/src/coffee/index.coffee
@@ -2,7 +2,7 @@ leveldb = exports = module.exports = require './leveldb/handle'
 binding = require './leveldb.node'
 
 leveldb.version = '0.6.1'
-leveldb.bindingVersion = binding.bindingVersion
+leveldb.bindingVersion = "#{binding.majorVersion}.#{binding.minorVersion}"
 
 leveldb.Batch = require('./leveldb/batch').Batch
 

diff --git a/src/cpp/handle.cc b/src/cpp/handle.cc
@@ -589,10 +589,11 @@ void JHandle::Initialize(Handle<Object> target) {
   NODE_SET_METHOD(target, "repair", OpenAsync::Hook<RepairAsync>);
 
   // Set version
-  std::stringstream version;
-  version << leveldb::kMajorVersion << "." << leveldb::kMinorVersion;
-  target->Set(String::New("bindingVersion"),
-              String::New(version.str().c_str()),
+  target->Set(String::New("majorVersion"),
+              Integer::New(leveldb::kMajorVersion),
+              static_cast<PropertyAttribute>(ReadOnly|DontDelete));
+  target->Set(String::New("minorVersion"),
+              Integer::New(leveldb::kMinorVersion),
               static_cast<PropertyAttribute>(ReadOnly|DontDelete));
 }