Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed for the issue (#70) #75

Merged
merged 7 commits into from
Mar 12, 2023
Merged

fix: fixed for the issue (#70) #75

merged 7 commits into from
Mar 12, 2023

Conversation

myConsciousness
Copy link
Owner

1. Description

1.1. Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

1.2. Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

1.3. Related Issues

@myConsciousness myConsciousness self-assigned this Mar 12, 2023
@myConsciousness myConsciousness linked an issue Mar 12, 2023 that may be closed by this pull request
Improve Suggestion: Move BaseService to atproto_core #70
Closed
@github-actions github-actions bot added atproto A label indicating the package `atproto`. atproto_core A label indicating the package `atproto_core`. bluesky A label indicating the package `bluesky`. bsky/lexicon/actors A label indicating the service related to `app.bsky.actor.*`. bsky/lexicon/feeds A label indicating the service related to `app.bsky.feed.*`. bsky/lexicon/notifications A label indicating the service related to `app.bsky.notification.*`. documentation Improvements or additions to documentation test atproto/lexicon/repositories A label indicating the service related to `com.atproto.repo.*`. atproto/lexicon/sessions labels Mar 12, 2023
@myConsciousness myConsciousness merged commit 14b56e3 into main Mar 12, 2023
@myConsciousness myConsciousness deleted the 70-improve-suggestion-move-baseservice-to-atproto_core branch March 12, 2023 11:11
@myConsciousness myConsciousness mentioned this pull request Mar 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@myConsciousness myConsciousness

Labels
atproto_core A label indicating the package `atproto_core`. atproto/lexicon/repositories A label indicating the service related to `com.atproto.repo.*`. atproto A label indicating the package `atproto`. bluesky A label indicating the package `bluesky`. bsky/lexicon/actors A label indicating the service related to `app.bsky.actor.*`. bsky/lexicon/feeds A label indicating the service related to `app.bsky.feed.*`. bsky/lexicon/notifications A label indicating the service related to `app.bsky.notification.*`. documentation Improvements or additions to documentation test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Suggestion: Move BaseService to atproto_core
1 participant
@myConsciousness